Skip to content

The suite page says what the presentation package requires #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabeat merged 1 commit into from
Oct 30, 2026
Merged

The suite page says what the presentation package requires #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions content/suite/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,11 @@ project on 7.2 or 7.3 cannot install the pair together.

`ext-imagick` is in `suggest` for both, and buys SVG. See [Images](/images/).

The presentation package pins `phpoffice/phppresentation` to a **commit on `dev-master`**, not a
tag, because the fixes it needs are not in a release. That is why `composer validate` runs without
`--strict` there: the pin is a warning, and the warning is the point.
The presentation package requires `phpoffice/phppresentation` at `~1.2.0` — a range of tags, and
`composer validate --strict` passes there. The fixes it needs are not in that release, so they
come from a **patch the library applies to the installed package**: a project that installs the
package has to allow the `cweagans/composer-patches` plugin for the patch to land. The library's
[README](https://github.com/markdown-office/markdown-presentation#installation) has the details.

## The conventions they share

Expand Down
2 changes: 2 additions & 0 deletions tools/check-command-line.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@
'the presentation index claimed to use every frontmatter key' => 'Every frontmatter key on a deck',
'the Word page said the container form of a drawn name is claimed' => 'the body is **silently dropped**',
'the errors page called a loss by a method it does not have' => '$loss->feature()',
'the suite page said the presentation pins a commit on dev-master' => 'to a **commit on `dev-master`**',
'the suite page said the presentation validates without --strict' => '`composer validate` runs without',
];

/**
Expand Down
Loading