Repository navigation
The suite page says what the presentation package requires - #20
Merged
Merged
Conversation
The page said the presentation package pins `phpoffice/phppresentation` to a commit on `dev-master`, and that `composer validate` runs without `--strict` there because the pin is a warning. Neither is true: the package requires `~1.2.0`, which is a range of tags, and `composer validate --strict` passes. The fixes the package needs are not in that release, so they come from a patch the library applies to the installed package — the patch its `extra.patches` names, and the one its README explains. The page says that now, and points at the README rather than repeating how the patch is applied. Both sentences are in the FORBIDDEN map, so a page that says either of them again is a failure.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suite page said:
Every clause of that is false. The package requires
~1.2.0— a range of tags — andcomposer validate --strictpasses there. The fixes it needs are not in that release, so they come from a patch the library applies to the installed package, and a project that installs it has to allow thecweagans/composer-patchesplugin for the patch to land. The library's README has the details.The page has been wrong since
8d23157inmarkdown-office/markdown-presentation— before this release cycle — and nothing checked the sentence.The claim is pinned
tools/check-command-line.phphas aFORBIDDENmap, because a sentence that was wrong is wrong wherever it is written. Both false clauses are now entries:With the old paragraph restored, the check fails with both problems; with the new one it passes.
It does not wait for the release
This is a documentation fix, not part of the release, so it stands on its own.