Repository navigation
fix(flatfield): crop detection reads the render's flat-fielded source - #1360
Merged
marcinz606 merged 1 commit intoOct 11, 2026
Merged
marcinz606 merged 1 commit into
marcinz606 merged 1 commit into
Conversation
thetalkingdrum
force-pushed
the
fix/detection-flatfield-half-stitch
branch
from
October 11, 2026 14:34
9140221 to
ee59c48
Compare
Auto-crop all frames and Auto Skew applied the whole-frame gain to one half of a half-frame scan, stretched over the half, and applied it a second time to a stitch whose parts the decode had already corrected. Both now pass the half-frame cut and skip a stitch, as run_pipeline and Roll Analysis do.
thetalkingdrum
force-pushed
the
fix/detection-flatfield-half-stitch
branch
from
October 11, 2026 15:19
ee59c48 to
c65a6f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-crop all frames and Auto Skew applied the Flat Field differently from the render. On a half-frame scan they applied the whole-frame gain to one half, stretched across it, and on a stitch they applied it a second time to parts the decode had already corrected. Both now pass the half-frame or diptych cut and skip stitches, behind the same gate
run_pipelineand Roll Analysis use.