Repository navigation
refactor(flatfield): one helper for the render's flat-fielded source - #1362
Merged
marcinz606 merged 1 commit intoOct 11, 2026
Merged
Conversation
run_pipeline, Normalization, Auto-crop all frames and Auto Skew each repeated the stitch / embedded-lens gate, the half-frame gain cut and the orientation turn. flatfield_source() in services/rendering/lens.py holds that logic once, so the four paths cannot drift. No behavior change; run_pipeline keeps its skip_flatfield flag at the call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1360 made Auto-crop all frames and Auto Skew apply the Flat Field the way the render does. That left four copies of the same block, in
run_pipeline, Roll Analysis and the two detection paths: skip a stitch or an embedded-lens frame, cut the gain to the half frame, and turn it by the frame's tag (#1359). The detection paths had already drifted from the render once, which is what #1360 fixed.flatfield_source()inservices/rendering/lens.pynow holds that block, and all four call sites use it. Behaviour is unchanged. A new test covers the helper's skip, cut and turn, andmake allpasses.