fix: add DeprecationWarning to geneset() and snp_dataset()#1286
Open
Tanisha127 wants to merge 3 commits intomalariagen:masterfrom
Open
fix: add DeprecationWarning to geneset() and snp_dataset()#1286Tanisha127 wants to merge 3 commits intomalariagen:masterfrom
Tanisha127 wants to merge 3 commits intomalariagen:masterfrom
Conversation
Contributor
Author
|
Hi @jonbrenas, |
Contributor
|
Hey, Thanks for working on this. I actually opened a PR earlier addressing the same issue (#1273), but it hasn’t been reviewed yet. I wanted to ask, does your implementation introduce anything different in terms of approach or behavior compared to what was previously proposed? Just trying to understand if there are key differences or improvements so we can avoid duplicating effort. Appreciate it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1285
What changed
warnings.warn(..., DeprecationWarning)togeneset()in genome_features.pywarnings.warn(..., DeprecationWarning)tosnp_dataset()in snp_data.pyWhy
Both methods were silently deprecated with no runtime warning to users.
Testing
All existing tests pass.