forked from lidge-jun/opencodex
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(devin): fail closed for legacy custom ACP rows #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
luvs01
wants to merge
31
commits into
dev
Choose a base branch
from
codex/propose-fix-for-acp-migration-vulnerability
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
06ec553
Merge pull request #3678 from lidge-jun/codex/promote-main-243-01a07240
lidge-jun 116c2ac
Merge commit '44ea9576e27c6be8be7f13a86e32bb349368c54d' into codex/re…
invalid-email-address 07b48da
Merge pull request #3785 from lidge-jun/codex/release-244-main-07c0
lidge-jun bcdf559
chore(release): promote validated 2.45.0 to main [skip ci]
invalid-email-address b0900e5
chore(release): promote 2.45.0 to main (#3813)
lidge-jun 3970601
chore(release): prepare 2.46.0 stable promotion
invalid-email-address bba6322
Merge pull request #3851 from lidge-jun/codex/release-246-main
lidge-jun 3d53e5f
release: prepare 2.47.0 from audited regression candidate
invalid-email-address eda8754
Merge commit '48ab3e1e66cfa6e0c873de2fafa4540ac61d6c7d' into codex/re…
invalid-email-address f9e3515
Merge commit '57252193b' into codex/release-247-main
invalid-email-address 6f71931
release: promote 2.47.0 to main (#3929)
lidge-jun 9a60256
Merge commit 'd0737cff3' into codex/release-247-main-final
invalid-email-address 9e9b1d3
Merge commit 'f48c322c0' into codex/release-247-main-final
invalid-email-address 947bae9
Merge commit '0d7652ad1' into codex/release-247-main-final
invalid-email-address f7f890f
release: apply final roster correction to main (#3933)
lidge-jun 544ebee
release: promote 2.48.0 to main
invalid-email-address d24ff57
release: set main channel version 2.48.0
invalid-email-address 9a27e86
Merge pull request #4011 from lidge-jun/codex/release-248-main
lidge-jun 62849df
release: promote verified 2.49.0 product tree to main
lidge-jun 2f3f736
Merge pull request #4117 from lidge-jun/codex/release-249-main-01a08498
lidge-jun 3a3de88
release: promote verified 2.50.0 product tree to main
lidge-jun 2d4d7a2
Merge pull request #4195 from lidge-jun/codex/release-250-main-01a08a81
lidge-jun cf456e8
release: promote verified 2.51.0 product tree to main
lidge-jun c155cc7
Merge pull request #4271 from lidge-jun/codex/release-251-main
lidge-jun 95c4875
release: promote verified 2.52.0 product tree to main
lidge-jun 4d37c35
Merge pull request #4407 from lidge-jun/codex/release-2520-main
lidge-jun 641b05a
release: promote verified 2.53.0 product tree to main
lidge-jun aa05b3e
Merge pull request #4507 from lidge-jun/codex/release-2530-main
lidge-jun 8e532c5
release: promote verified 2.54.0 product tree to main
lidge-jun 9f7397e
Merge pull request #4540 from lidge-jun/codex/release-2540-main
lidge-jun c70fe8d
fix(devin): fail closed for legacy custom ACP rows
luvs01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a legacy custom row also has a valid
modelAdapters[model]value, thiscontinuepreserves that override;resolveWireProtocolOverride()insrc/server/adapter-resolve.ts:35-45then replaces the unknowndevin-cliadapter withopenai-chatoropenai-responsesbefore adapter construction. The request therefore does not fail closed and can send a configured API key to the legacy row's savedbaseUrl, even though the removed ACP adapter ignored that credential. Remove/disable these overrides during migration or reject the retired adapter before model-level wire resolution.AGENTS.md reference: AGENTS.md:L366-L372
Useful? React with 👍 / 👎.