Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c70fe8d74f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `left custom provider "${name}" disabled because adapter ${RETIRED_ACP_ADAPTER} was removed: ` | ||
| + "choose adapter devin and configure Devin authentication explicitly before using this provider.", | ||
| ); | ||
| continue; |
There was a problem hiding this comment.
When a legacy custom row also has a valid modelAdapters[model] value, this continue preserves that override; resolveWireProtocolOverride() in src/server/adapter-resolve.ts:35-45 then replaces the unknown devin-cli adapter with openai-chat or openai-responses before adapter construction. The request therefore does not fail closed and can send a configured API key to the legacy row's saved baseUrl, even though the removed ACP adapter ignored that credential. Remove/disable these overrides during migration or reject the retired adapter before model-level wire resolution.
AGENTS.md reference: AGENTS.md:L366-L372
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
1 participant
Motivation
devin-cliACP adapter into the clouddevinadapter, which could cause unrelated caller bearers or stored keys to be treated as Devin credentials and be forwarded to Cognition.Description
projectDevinCliAuthModeinsrc/providers/devin-cli-authmode-migration.tsto leave custom-named rows that still referencedevin-cliunchanged and emit an actionable startup warning instead of rewriting them todevin(fail-closed behavior).devin-cli->devinmigration for the registry-id row; only custom-named rows are disabled pending operator configuration.tests/providers/devin-cli-authmode-migration.test.tsto assert that a customdevin-acprow is left disabled and that the registry-id row still migrates.Testing
bun test tests/providers/devin-cli-authmode-migration.test.ts, which passed.bun run typecheck,bun run privacy:scan, andbun run structure:check, all of which passed.cd docs-site && bun install --frozen-lockfile && bun run build, which succeeded.git diff --checkto ensure no whitespace/patch issues, which passed.bun run test) for context; the focused change passes, while the full repo run exposed unrelated environment/container and lab-test failures documented elsewhere and not caused by this change.Codex Task