test: trigger preview retirement after the initial result - #5550
Open
huangruiteng wants to merge 1 commit into
Open
huangruiteng wants to merge 1 commit into
huangruiteng wants to merge 1 commit into
Conversation
Signed-off-by: huangruiteng <huangrt01@163.com>
This was referenced Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retirement recovery test shortens the five-minute worker lifetime to 200ms from spawn. On a slow worker, that can retire the first accepted request before its result, so the test never reaches the intended second-request cleanup race. A synthetic 350ms worker startup delay reproduces the lifetime failure on the current main baseline
99839aeb8fed5fae38a5d319391cd050672a6508(idle and broken-pipe variants pass).Advance the selected retirement timers through a test-only SIGUSR2 preload after the first preview has completed. The real Host cleanup grace, request deadline, process-group ownership and retirement fence remain in use. Add ready/350ms worker variants for idle, lifetime and broken-pipe retirement. Cleared timer handles are excluded; the replacement supervisor retains its original production clocks. No production code or timeout changes.
Validation on macOS / Node 24.21.0 / Python 3.12.15:
tests/test_delegation_preview_reuse.py: 41 passed.delegation_preview_bridge,host_process_groupandhost_processTypeScript tests: 24 passed.git diff --check: passed.Linux qualification remains required. This fixes a demonstrated test timing defect; it does not establish that every Linux CI failure has the same cause. The separate
test_retry_safe_typed_write_recovers_after_unexpected_runtime_exitfailure remains unexplained: 25 consecutive current-main macOS trials pass, which is not a Linux waiver. Existing accepted-request failure/uncertain-cleanup tests are retained. No model, live connector or production installation was changed.Linux CI checkpoint on exact head
b201ba28941b7af3b57bf8fb33bfd5080be4720c: all six new ready/slow-worker retirement variants are passed in the four uploaded Python JUnit shard artifacts from run37171421012. The separate unexpected-exit typed-write recovery case also passed in that run. Overall CI remains failed (72 failing test names); the preview suite has 40 passed and one existing backpressure/deadline failure. These artifacts qualify the six cases, without attributing or waiving other failures or the earlier unexplained runtime exit.