fix: stop POSIX preview input at its parent deadline - #5553
Open
huangruiteng wants to merge 1 commit into
Open
huangruiteng wants to merge 1 commit into
huangruiteng wants to merge 1 commit into
Conversation
Signed-off-by: huangruiteng <huangrt01@163.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A backpressured preview send can report its parent timeout while the background pipe writer remains alive. When reader capacity returns, that writer can finish a complete request frame after the deadline. The real-pipe counterexample fails on main for both 64 KiB and 512 KiB inputs.
Use nonblocking POSIX pipe writes and readiness waits against the original monotonic deadline. Timeout leaves no background input writer to finish the frame or retain the write end during cleanup. Keep the existing Windows pipe path, TS Host/process-group cleanup, retirement fence and retry rules. This is a transport repair under S4/S10 and R1 recovery; it creates no queue, runner, authority or protocol vocabulary.
Validation on macOS / Node 24.21.0 / Python 3.12.15:
This independently targets main
99839aeb8fed5fae38a5d319391cd050672a6508. It does not include the separate retirement-clock change in #5550. The previous Linux CI cleanup timeout is still not attributed or waived by the macOS counterexample; exact-head Linux/Windows CI and maintainer review remain required. Tests use synthetic processes/configuration. The running source candidate and formal installation were not changed by this validation.