Skip to content

overlay: exact wave 6 (10 more overlay functions in exact c) - #171

Merged
mateuszklysz merged 13 commits into
mainfrom
decomp/exact-wave-6
Oct 13, 2026
Merged

mateuszklysz merged 13 commits into
mainfrom
decomp/exact-wave-6

Conversation

@mateuszklysz

@mateuszklysz mateuszklysz commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Before

Ten level functions were still retail asm (INCLUDE_ASM), several with a NON_MATCHING draft beside them.

After

All ten are exact C:

  • Ported from rac1-decomp: FUN_L07_002f5ba0, FUN_L00_002c6158, FUN_L00_002b87e0, FUN_L00_002b03a0, FUN_L11_0030b358, FUN_L00_00245c28, FUN_L13_002b50d8.
  • Own: FUN_L00_002599e8, FUN_L00_002092c8 (pose packer), FUN_L06_0030bfa8 (screen-space sprite; the corners are built from one base plus += like the other sprite helpers).
  • shared/rendering/00245c28.c now builds with SN (configure.py dict); overlay_game_state.h gains unk13C.
  • Ported aliases with port-address names now use the US label plus the unit suffix.

Verification

  • make elf ends with PASS: reconstructed boot ELF matches retail
  • make overlays ends with PASS (overlay changes)
  • make check passes

@mateuszklysz mateuszklysz added the enhancement New feature or request label Oct 13, 2026 — with Claude
@decomp-dev

decomp-dev Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Report for SCUS_971.99 (794c330 - a9c29c2)

📈 Matched code: 86.55% (+0.81%, +28600 bytes)
📈 Linked code: 86.55% (+0.81%, +28600 bytes)

✅ 10 new matches
Unit Item Bytes Before After
level_13/gameplay/entities/002b0e80 FUN_L13_002b50d8 +10404 0.00% 100.00%
shared/gameplay/entities/002aa670 FUN_L00_002b03a0 +5964 0.00% 100.00%
shared/gameplay/entities/002bffa8 FUN_L00_002c6158 +3628 0.00% 100.00%
shared/gameplay/entities/002b2100 FUN_L00_002b87e0 +2860 0.00% 100.00%
shared/rendering/00245c28 FUN_L00_00245c28 +2176 0.00% 100.00%
level_07/gameplay/entities/002cd2b0 FUN_L07_002f5ba0 +1320 0.00% 100.00%
shared/gameplay/entities/002c8830 FUN_L11_0030b358 +984 0.00% 100.00%
shared/ui/help/00203b18 FUN_L00_002092c8 +632 0.00% 100.00%
shared/gameplay/vendor/00307578 FUN_L06_0030bfa8 +472 0.00% 100.00%
shared/gameplay/entities/00259710 FUN_L00_002599e8 +160 0.00% 100.00%

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Decompilation progress

C_EXACT Change Matched bytes Functions C_FUZZY
All code 86.55 % +0.81 pp 3,069,248 / 3,546,268 B (+28,600 B) 3,933 / 4,233 (+10) 87.88 %
Boot executable 84.73 % — 298,968 / 352,840 B (—) 1,159 / 1,219 (—) 98.11 %
Game 84.26 % — 229,892 / 272,844 B (—) 865 / 905 (—) 98.40 %
SDK 86.35 % — 69,076 / 79,996 B (—) 294 / 314 (—) 97.12 %
Level overlays 86.75 % +0.90 pp 2,770,280 / 3,193,428 B (+28,600 B) 2,774 / 3,014 (+10) 86.75 %
Shared level code 78.82 % +1.49 pp 891,052 / 1,130,492 B (+16,876 B) 1,428 / 1,583 (+8) 78.82 %
Per-level code 91.09 % +0.57 pp 1,879,228 / 2,062,936 B (+11,724 B) 1,346 / 1,431 (+2) 91.09 %
9 newly matched functions (28,128 B)
Function Address Size Unit
FUN_L13_002b50d8 0x002b50d8 10,404 B level_13/gameplay/entities/002b0e80
FUN_L00_002b03a0 0x002b03a0 5,964 B shared/gameplay/entities/002aa670
FUN_L00_002c6158 0x002c6158 3,628 B shared/gameplay/entities/002bffa8
FUN_L00_002b87e0 0x002b87e0 2,860 B shared/gameplay/entities/002b2100
FUN_L00_00245c28 0x00245c28 2,176 B shared/rendering/00245c28
FUN_L07_002f5ba0 0x002f5ba0 1,320 B level_07/gameplay/entities/002cd2b0
FUN_L11_0030b358 0x0030b358 984 B shared/gameplay/entities/002c8830
FUN_L00_002092c8 0x002092c8 632 B shared/ui/help/00203b18
FUN_L00_002599e8 0x002599e8 160 B shared/gameplay/entities/00259710

Compared with main (794c330). C_FUZZY uses main's last measurement.

@mateuszklysz
mateuszklysz merged commit e934c0a into main Oct 13, 2026
3 checks passed
@mateuszklysz
mateuszklysz deleted the decomp/exact-wave-6 branch October 13, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant