Skip to content

fix: unsubscribe FFI queue when the room listen task ends #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
longcw merged 2 commits into from
Jun 4, 2026
Merged

fix: unsubscribe FFI queue when the room listen task ends #699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed188b9
fix: unsubscribe FFI queue when the room listen task ends
longcw Jun 3, 2026
8a48dab
fix ruff
longcw Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions livekit-rtc/livekit/rtc/room.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,12 @@ def on_participant_connected(participant):
# start listening to room events
self._task = self._loop.create_task(self._listen_task())

# unsubscribe from the FFI queue once the listen task ends.
# disconnect() unsubscribes too, but it early-returns when the
# room is already disconnected (e.g. removed remotely).
ffi_queue = self._ffi_queue
self._task.add_done_callback(lambda _: FfiClient.instance.queue.unsubscribe(ffi_queue))

# Unblock the FFI server once this SDK is ready to receive room events.
ready_req = proto_ffi.FfiRequest()
ready_req.ready_for_room_event.room_handle = self._ffi_handle.handle
Expand Down