fix: unsubscribe FFI queue when the room listen task ends#699
Merged
Conversation
longcw
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
theomonnom
approved these changes
Jun 3, 2026
cloudwebrtc
approved these changes
Jun 3, 2026
Contributor
|
sorry for being late on review, it looks good to me too. Thanks for fixing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a room is disconnected remotely (e.g. the participant is removed),
Room.disconnect()early-returns onnot isconnected()and never unsubscribes the room's FFI event queue. The FFI receive thread keeps posting events to it, and once the event loop closes it logserror putting to queue: Event loop is closed.Unsubscribe the FFI queue in a done callback on the listen task, so the subscription's lifetime matches its only consumer (
_listen_task) regardless of how it ends — EOS, error, or cancellation.unsubscribeis idempotent, so the existing calls indisconnect()and__del__stay harmless.