Skip to content

feat: name the SIP flags --trunk, --from-phone-number and --to-phone-number #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
u9g wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −13
Open

feat: name the SIP flags --trunk, --from-phone-number and --to-phone-number #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ebb186
feat(sip): name the participant create number flags --from-phone-numb…
u9g Oct 27, 2026
4400575
refactor(simulate): name the SIP trunk flag --trunk
u9g Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cmd/lk/simulate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,12 @@ var simulateAudioCommand = &cli.Command{
Usage: "Call this `NUMBER` over SIP and simulate against whoever answers, instead of dispatching an agent. Requires --from-phone-number and --scenarios.",
},
&cli.StringFlag{
Name: "from-trunk",
Name: "trunk",
Usage: "Outbound SIP trunk `ID` to place --to-phone-number calls through. Without it, calls go out from a LiveKit phone number.",
},
&cli.StringFlag{
Name: "from-phone-number",
Usage: "Caller `NUMBER` for --to-phone-number calls: a LiveKit phone number the project owns, or a number on --from-trunk",
Usage: "Caller `NUMBER` for --to-phone-number calls: a LiveKit phone number the project owns, or a number on --trunk",
},
},
}
Expand Down Expand Up @@ -539,14 +539,14 @@ func runSimulate(ctx context.Context, cmd *cli.Command, simulationMode livekit.S
samples := int32(cmd.Int("samples"))
passRate := cmd.Float("pass-rate")
liveAgentName := cmd.String("agent-name")
var phoneNumber, fromTrunk, fromPhoneNumber string
var phoneNumber, trunkID, fromPhoneNumber string
if simulationMode == livekit.SimulationMode_SIMULATION_MODE_AUDIO {
phoneNumber = cmd.String("to-phone-number")
fromTrunk = cmd.String("from-trunk")
trunkID = cmd.String("trunk")
fromPhoneNumber = cmd.String("from-phone-number")
}
if fromTrunk != "" && phoneNumber == "" {
return fmt.Errorf("--from-trunk requires --to-phone-number")
if trunkID != "" && phoneNumber == "" {
return fmt.Errorf("--trunk requires --to-phone-number")
}
if fromPhoneNumber != "" && phoneNumber == "" {
return fmt.Errorf("--from-phone-number requires --to-phone-number")
Expand Down Expand Up @@ -668,7 +668,7 @@ func runSimulate(ctx context.Context, cmd *cli.Command, simulationMode livekit.S
simCfg.lowQualityMicrophone = cmd.Bool("low-quality-microphone")
simCfg.packetLoss = cmd.Bool("packet-loss")
simCfg.sipCallTo = phoneNumber
simCfg.sipTrunkID = fromTrunk
simCfg.sipTrunkID = trunkID
simCfg.sipNumber = fromPhoneNumber
}

Expand Down
14 changes: 8 additions & 6 deletions cmd/lk/sip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,14 @@ var (
Usage: "`SIP_TRUNK_ID` to use for the call (overrides json config)",
},
&cli.StringFlag{
Name: "number",
Usage: "`SIP_NUMBER` to use for the call (overrides json config)",
Name: "from-phone-number",
Aliases: []string{"number"},
Usage: "`SIP_NUMBER` to use for the call (overrides json config)",
},
&cli.StringFlag{
Name: "call",
Usage: "`SIP_CALL_TO` number to use (overrides json config)",
Name: "to-phone-number",
Aliases: []string{"call"},
Usage: "`SIP_CALL_TO` number to use (overrides json config)",
},
&cli.StringFlag{
Name: "name",
Expand Down Expand Up @@ -1273,10 +1275,10 @@ func createSIPParticipant(ctx context.Context, cmd *cli.Command) error {
if v := cmd.String("trunk"); v != "" {
req.SipTrunkId = v
}
if v := cmd.String("number"); v != "" {
if v := cmd.String("from-phone-number"); v != "" {
req.SipNumber = v
}
if v := cmd.String("call"); v != "" {
if v := cmd.String("to-phone-number"); v != "" {
req.SipCallTo = v
}
if v := cmd.String("room"); v != "" {
Expand Down
Loading