Skip to content

feat: name the SIP flags --trunk, --from-phone-number and --to-phone-number - #1083

Open
u9g wants to merge 2 commits into
mainfrom
jason/sip-phone-number-flags
Open

u9g wants to merge 2 commits into
mainfrom
jason/sip-phone-number-flags

Conversation

@u9g

@u9g u9g commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

lk sip participant create and lk agent simulate audio now use the same names for the same CreateSIPParticipantRequest fields:

Field lk sip participant create lk agent simulate audio
sip_trunk_id --trunk --trunk (was --from-trunk)
sip_number --from-phone-number (alias --number) --from-phone-number
sip_call_to --to-phone-number (alias --call) --to-phone-number
$ lk sip participant create --help
   --trunk SIP_TRUNK_ID                                 SIP_TRUNK_ID to use for the call (overrides json config)
   --from-phone-number SIP_NUMBER, --number SIP_NUMBER  SIP_NUMBER to use for the call (overrides json config)
   --to-phone-number SIP_CALL_TO, --call SIP_CALL_TO    SIP_CALL_TO number to use (overrides json config)

Checked with --verbose: both --from-phone-number +15105550199 --to-phone-number +14155550100 and --number +15105550199 --call +14155550100 build the same request (sipNumber: +15105550199, sipCallTo: +14155550100).

Commits

  1. feat(sip): name the participant create number flags --from-phone-number and --to-phone-number
  2. refactor(simulate): name the SIP trunk flag --trunk

…er and --to-phone-number

`--number` and `--call` stay as aliases, so existing scripts keep working.
@u9g

u9g commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

lk sip participant create --help lists --from-phone-number and --to-phone-number, with --number and --call as aliases. --verbose shows the new and old names build the same request. lk agent simulate audio uses the same --trunk, --from-phone-number and --to-phone-number names.

sip-flags.mp4

Matches `lk sip participant create --trunk`. --from-trunk was never released.
@u9g u9g changed the title feat(sip): name the participant create number flags --from-phone-number and --to-phone-number feat: name the SIP flags --trunk, --from-phone-number and --to-phone-number Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant