Repository navigation
Conversation
…er and --to-phone-number `--number` and `--call` stay as aliases, so existing scripts keep working.
Contributor
Author
|
sip-flags.mp4 |
Matches `lk sip participant create --trunk`. --from-trunk was never released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lk sip participant createandlk agent simulate audionow use the same names for the sameCreateSIPParticipantRequestfields:lk sip participant createlk agent simulate audiosip_trunk_id--trunk--trunk(was--from-trunk)sip_number--from-phone-number(alias--number)--from-phone-numbersip_call_to--to-phone-number(alias--call)--to-phone-numberlk sip participant createkeeps--numberand--callas aliases, so existing scripts and docs don't break.lk agent simulate audio --from-trunkcame from feat(simulate): run audio simulations against a phone number with --to-phone-number #1035 and isn't in a release yet, so it's renamed without an alias.Checked with
--verbose: both--from-phone-number +15105550199 --to-phone-number +14155550100and--number +15105550199 --call +14155550100build the same request (sipNumber: +15105550199,sipCallTo: +14155550100).Commits
feat(sip): name the participant create number flags --from-phone-number and --to-phone-numberrefactor(simulate): name the SIP trunk flag --trunk