Repository navigation
Adopt native SDK 0.1.0 - #21
Merged
Merged
Conversation
- Bump LinkTrailSDK to ~> 0.1.0 and io.linktrail:sdk to 0.1.0 - Paste button uses the native paste path; new optional grantsConsent prop (default: grant only while undecided) - Android reports X-LinkTrail-SDK: react-native/<package version> - Document linkDomains migration and customData JSON-string values - Version 0.1.0
Contributor
Author
|
Impact: No DB changes. Live code: the published npm package (at release) and the native SDK versions apps get. Breaking for integrators: link handling is limited to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
Moves the wrapper to the native 0.1.0 SDKs and releases it as 0.1.0.
Changes
LinkTrailSDK ~> 0.1.0(podspec; examplePodfile.locknow resolves 0.1.0). Androidio.linktrail:sdk:0.1.0.linkDomainsis already inconfigureoptions and forwarded to both natives. Updated its docs, plus a README and CHANGELOG migration note: custom link domains must be listed inlinkDomains;handleDeepLinknow ignores non-LinkTrail URLs (it resolvesnullwith no network call and noonError).LinkTrailPasteButton(grantsConsent:onToken:).makeCoordinator()) inside the existing themeableUIPasteControl. That gives the native consent rule and the fix for tokens pasted after a denial. Before, the bridge calledtrackInstall(clickToken:)directly. New optionalgrantsConsent?: booleanprop. If you omit it, the bridge passes nativenil(grant only while consent is undecided).trueandfalsemap to the native values.X-LinkTrail-SDKheader: Android callsLinkTrailWrapper.setPlatform("react-native", BuildConfig.LINKTRAIL_RN_VERSION)beforeconfigure. The version is read frompackage.jsonbybuild.gradle. iOS isn't wired yet: the publishedLinkTrailSDK0.1.0 XCFramework ships no.private.swiftinterface, so the@_spi(Wrapper) setSDKIdentifier(platform:version:)hook can't be called from another module. Until a native release exposes it, iOS keeps sendingios/<native version>.customData: the type staysRecord<string, string>. The docs now say that nested values arrive as JSON strings.configuresingleton behaviour. Version 0.1.0, CHANGELOG entry with upgrade notes.Verified
npm run lint(0 errors),npm run typecheck,npm run prepare, codegen validation (the newgrantsConsentenum prop is generated).pod installresolvesLinkTrailSDK 0.1.0, andxcodebuildfor the simulator succeeds.io.linktrail:sdk:0.1.0is published on Maven Central and resolves.