Repository navigation
README: 0.1.0 linking, consent and delivery docs - #24
Merged
Merged
Conversation
Add the iOS AppDelegate RCTLinkingManager wiring (open url and continue userActivity, Swift and Objective-C) and the Android App Links filter. Document linkDomains as required for custom domains with an upgrade snippet, the configure singleton, deferred link delivery (at least once, 7-day expiry, subscribe before configure), resetForTesting, the 0.1.0 consent outcomes (deny sends one consent:false install) and how the paste button handles consent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only (README.md). Follow-up to #21, which merged and shipped as 0.1.0 before these README fixes were ready, so they go in a separate PR. The npm README updates on the next publish; GitHub shows it on merge.
Changes
AppDelegatemust forwardopen urlandcontinue userActivitytoRCTLinkingManager, or Universal Links open the app butonLinknever fires. Swift (RN 0.77+) and Objective-C (RN 0.76) snippets, matchingexample/ios/KickFlip/AppDelegate.swift. Android App Links filter added too.linkDomains: required for custom domains from 0.1.0 (*.linktrail.ioalways claimed), with an upgrade snippet. Quick start now shows it. Custom schemes are described as the app's own routing.configuresingleton: same key/options is a no-op; different options replace the native instance; JS subscriptions stay valid (the bridge re-registers its native callbacks in everyconfigure).onLinkinsideconfigureand doesn't buffer for a late JS listener, so the README says to subscribe beforeconfigure(the buffering lands in Wrapper parity 0.1.1: link buffering, camelCase errors, version #23).consent: falseinstall with no device id (routes, records nothing);setConsent(false)wins even withrequireConsent: false.trackInstallWithClickTokenfromonTokenPasted.resetForTesting: one paragraph.Conflicts with #23 (it also edits README.md). Whichever merges second needs a small rebase; #23 should then replace the 'subscribe before configure' paragraph with its buffering behaviour.
Impact
No DB changes, no code changes. Docs only; no production impact.