Repository navigation
Conversation
beekld
marked this pull request as ready for review
November 2, 2026 21:05
beekld
force-pushed
the
bklimt/SDK-2986/fdv1-fallback-default-ttl
branch
from
November 2, 2026 21:59
9945ce8 to
659af57
Compare
beekld
force-pushed
the
bklimt/SDK-2986/fdv1-fallback-default-ttl
branch
from
November 3, 2026 00:05
659af57 to
8ece332
Compare
beekld
force-pushed
the
bklimt/SDK-2986/fdv1-fallback-default-ttl
branch
from
November 3, 2026 19:38
8ece332 to
8a0d727
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8a0d727. Configure here.
tanderson-ld
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
An FDv1 fallback directive used to be permanent. Once a synchronizer or initializer sent one, the data system never went back to its FDv2 synchronizers. With no FDv1 fallback synchronizer configured, the synchronizer loop exited, and the data system reported
Interruptedfor the life of the client.A fallback now lasts for a default TTL of one hour, minus a random jitter of up to half of it, and then the data system returns to its FDv2 synchronizers:
Interruptedwith the error of the directive and runs no synchronizer until the TTL elapses.A directive that brings no data no longer raises readiness. With no FDv1 fallback synchronizer,
MakeClientnow returnsErrInitializationTimeoutafter its full wait, instead ofErrInitializationFailedat once.Every fallback uses the default TTL. Supporting a TTL carried by the directive itself would be a breaking change.
Note
Overview
FDv1 fallback directives are time-limited instead of permanent. When an initializer or synchronizer requests fallback, the data system applies a default TTL of one hour (with up to half-duration jitter via shared
jittered()), tracksfdv1FallbackUntilon the synchronizer list, and returns to configured FDv2 synchronizers when it expires—via the backoff wait loop, the 10s condition ticker (syncFDv1FallbackEnded), ormaybeEndFDv1Fallback().With an FDv1 fallback synchronizer, only that slot runs until the TTL ends; without one, status stays
Interrupted(with the directive error) and no FDv2 synchronizer runs until the TTL elapses—replacing the oldexcludeAll()path that stopped the loop for good.Initialization / readiness shifts when fallback brings no data: the ready channel is not closed immediately, so
MakeCustomClientcan hitErrInitializationTimeoutrather than failing init at once. E2E tests now assertInterruptedinstead ofOff.LDRelayApplySDKKeydocs now state that an SDK key change does not end an active FDv1 fallback (only unparks backoff).Reviewed by Cursor Bugbot for commit de5722e. Bugbot is set up for automated code reviews on this repo. Configure here.