Skip to content

fix(python): fix broken pylance benchmark scripts #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mocobeta wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(python): fix broken pylance benchmark scripts #7744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d564aca
set num_sub_vectors for ivfpq index creation
mocobeta Jul 12, 2026
fa6c869
use consistent value for num_sub_vectors
mocobeta Jul 12, 2026
079cc8c
add benchmark dependencies
mocobeta Jul 12, 2026
5a1722c
fix typo in fixture name
mocobeta Jul 12, 2026
f9ae52e
fix assertion
mocobeta Jul 12, 2026
65582a0
fix assertion
mocobeta Jul 12, 2026
dbdc9a6
update num_sub_vectors value
mocobeta Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ dev = [
]
benchmarks = [
"pytest-benchmark==5.1.0",
"torch>=2.0",
"geoarrow-rust-core",
"geoarrow-rust-io",
]

[tool.uv]
Expand Down
4 changes: 2 additions & 2 deletions python/python/benchmarks/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def sample():

result = benchmark.pedantic(sample, rounds=30, iterations=1)

assert result.num_rows == NUM_ROWS
assert result.num_rows == len(indices)


@pytest.mark.benchmark(group="sample_single_column")
Expand Down Expand Up @@ -216,4 +216,4 @@ def sample():

result = benchmark.pedantic(sample, rounds=30, iterations=1)

assert result.num_rows == NUM_ROWS
assert result.num_rows == len(indices)
3 changes: 2 additions & 1 deletion python/python/benchmarks/test_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ def test_optimize_index(
index_type="IVF_PQ",
metric_type="L2",
num_partitions=num_partitions,
num_sub_vectors=2,
num_bits=8,
replace=True,
)
Expand Down Expand Up @@ -205,7 +206,7 @@ def gen_rand_part_ids(dataset, dest_uri):


@pytest.mark.benchmark(group="transform_vectors")
def test_transform_vectors_no_precomputed_parts(test, tmpdir, benchmark):
def test_transform_vectors_no_precomputed_parts(test_dataset, tmpdir, benchmark):
ivf = rand_ivf(test_dataset)
pq = rand_pq(test_dataset, ivf)
builder = IndicesBuilder(test_dataset, "vector")
Expand Down
92 changes: 9 additions & 83 deletions python/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading