fix(python): fix broken pylance benchmark scripts#7744
Open
mocobeta wants to merge 7 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughBenchmark dependencies are expanded, sampling benchmarks assert sampled row counts, IVF-PQ optimization specifies sub-vector configuration, and vector transformation uses the dataset fixture. ChangesBenchmark updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmarks in
python/benchmarksseem broken or obsolete. This PR fixes various minor issues in the benchmark scripts.benchmarksgroup.test_index.py.num_sub_vectorsparam when creating IVF_PQ index intest_index.py.test_file.py. The right side of the assertion should be the number of sampled rows, notNUM_ROWS.Run benchmarks on
mainbranchRun benchmarks on this branch
Summary by CodeRabbit
Summary by CodeRabbit
Chores
Bug Fixes