fix(java): reuse session for OpenDatasetBuilder.buildFromNamespaceClient#6536
Open
fangbo wants to merge 2 commits into
Open
fix(java): reuse session for OpenDatasetBuilder.buildFromNamespaceClient#6536fangbo wants to merge 2 commits into
fangbo wants to merge 2 commits into
Conversation
Contributor
Author
|
Related lance-format/lance-spark#353 cc @LuciferYang |
fangbo
force-pushed
the
set-session-open-dataset
branch
from
April 16, 2026 09:01
170b95e to
37b25f3
Compare
LuciferYang
approved these changes
Apr 16, 2026
LuciferYang
left a comment
LuciferYang
left a comment
Contributor
There was a problem hiding this comment.
nit: can we add a test that opens a dataset via namespace client with a ReadOptions-level session and verifies cache reuse would prevent this class of regression.
fangbo
force-pushed
the
set-session-open-dataset
branch
from
April 23, 2026 07:51
37b25f3 to
dcfc666
Compare
Contributor
Author
Thank you for advice. I have added a test case for this modification. |
fangbo
force-pushed
the
set-session-open-dataset
branch
from
April 24, 2026 02:09
c6c5ba4 to
4bd0467
Compare
fangbo
force-pushed
the
set-session-open-dataset
branch
from
April 24, 2026 07:13
4bd0467 to
ff5bce2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jackye1995 I think the session can be reused. Could you please take a look and see if this makes sense? Thank you.