feat(master): support etcd-backed HA scheduler#154
Merged
Conversation
…-store # Conflicts: # crates/lance-context-master/src/scheduler.rs # crates/lance-context-master/src/state.rs # crates/lance-context-master/src/task_store.rs
beinan
added a commit
that referenced
this pull request
Jul 16, 2026
## Summary - Remove the single-master RocksDB scheduler backend entirely. The master is now always etcd-backed and horizontally scalable — no `TASK_STORE_BACKEND` switch, no `TASK_DB_PATH`, no `rocksdb` dependency. - `TaskStore` wraps `EtcdTaskStore` directly (deleted `RocksTaskStore` and the `TaskStoreInner`/`ClaimBackend`/`GuardBackend` enums). - `ETCD_ENDPOINTS` is now required to start the master. - Deploy: delete the RocksDB `master.yaml`, promote `master-etcd.yaml` → `master.yaml`, rewrite the k8s README for etcd-only. ## Testing - `cargo build --workspace` ✅, `cargo clippy -p lance-context-master --tests` ✅ (clean), `cargo fmt` ✅ - `cargo test -p lance-context-master`: 7 passed, 17 ignored. Unit tests that build `MasterState`/`TaskStore` need a live etcd and are gated behind `ETCD_TEST_ENDPOINTS` (`#[ignore]`). Added `connect_requires_etcd_endpoints`. ## Note Branched fresh from `main` (which already carries the etcd backend, #154). Supersedes the single-master RocksDB lease work in #155 — with RocksDB gone, that guard is unnecessary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test -p lance-context-core -p lance-context-master --lib(core 135 passed, master 23 passed)cargo test -p lance-context-core --docETCD_TEST_ENDPOINTS=http://127.0.0.1:12379 cargo test -p lance-context-master task_store::tests::etcd_coordinates_dedupe_claims_and_target_locks -- --ignored --exactuv run pytest python/tests/ -v(3 passed)uv run ruff format --check python/uv run ruff check python/uv run pyright