refactor(master): drop RocksDB backend, etcd-only scheduler#157
Merged
Conversation
…store The RocksDB scheduler backend only ever supported a single master. Remove it entirely so the master is always stateless and horizontally scalable: - delete RocksTaskStore and the TaskStoreInner/ClaimBackend/GuardBackend enums; TaskStore now wraps EtcdTaskStore directly - remove TaskStoreBackend enum, TASK_STORE_BACKEND, and TASK_DB_PATH config - drop the rocksdb dependency - ETCD_ENDPOINTS is now required to start the master - unit tests that build MasterState/TaskStore now need a live etcd and are gated behind ETCD_TEST_ENDPOINTS (#[ignore]); add connect_requires_etcd_endpoints - deploy: delete rocksdb master.yaml, promote master-etcd.yaml to master.yaml, rewrite the kubernetes README for etcd-only Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TASK_STORE_BACKENDswitch, noTASK_DB_PATH, norocksdbdependency.TaskStorewrapsEtcdTaskStoredirectly (deletedRocksTaskStoreand theTaskStoreInner/ClaimBackend/GuardBackendenums).ETCD_ENDPOINTSis now required to start the master.master.yaml, promotemaster-etcd.yaml→master.yaml, rewrite the k8s README for etcd-only.Testing
cargo build --workspace✅,cargo clippy -p lance-context-master --tests✅ (clean),cargo fmt✅cargo test -p lance-context-master: 7 passed, 17 ignored. Unit tests that buildMasterState/TaskStoreneed a live etcd and are gated behindETCD_TEST_ENDPOINTS(#[ignore]). Addedconnect_requires_etcd_endpoints.Note
Branched fresh from
main(which already carries the etcd backend, #154). Supersedes the single-master RocksDB lease work in #155 — with RocksDB gone, that guard is unnecessary.🤖 Generated with Claude Code