Skip to content

Create webpack.yml #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laith-max merged 1 commit into from
May 19, 2026
Merged

Create webpack.yml #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/webpack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: NodeJS with Webpack

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18.x, 20.x, 22.x]

@cubic-dev-ai cubic-dev-ai Bot May 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Node 18.x is below the project's minimum engine requirement (node >= 20.0.0 in package.json). Remove it from the matrix to avoid guaranteed failures or testing against an unsupported runtime.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/webpack.yml, line 15:

<comment>Node 18.x is below the project's minimum engine requirement (`node >= 20.0.0` in package.json). Remove it from the matrix to avoid guaranteed failures or testing against an unsupported runtime.</comment>

<file context>
@@ -0,0 +1,28 @@
+
+    strategy:
+      matrix:
+        node-version: [18.x, 20.x, 22.x]
+
+    steps:
</file context>
Suggested change
node-version: [18.x, 20.x, 22.x]
node-version: [20.x, 22.x]
Fix with Cubic


steps:
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
Comment thread
laith-max marked this conversation as resolved.

- name: Build
run: |
npm install
npx webpack
Comment on lines +27 to +28

@sourcery-ai sourcery-ai Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Use npm ci (and optionally an npm script) instead of npm install + bare npx webpack.

In CI, npm ci is better suited than npm install because it uses the lockfile for reproducible installs and is faster on clean machines. Also consider calling webpack via an npm script (e.g. npm run build) so build options live in package.json and you don’t depend on npx or any global webpack installation.

Suggested implementation:

    - name: Build
      run: |
        npm ci
        npm run build

Ensure that your package.json defines a build script, e.g.:

{
  "scripts": {
    "build": "webpack"
  }
}

If your build requires specific webpack CLI options, include them in the "build" script instead of in the workflow.

Fix in Cursor

Loading