Create webpack.yml - #1
Merged
Merged
Conversation
Reviewer's GuideAdds a GitHub Actions workflow to build the project with Webpack on pushes and pull requests to main using multiple Node.js versions. Flow diagram for new GitHub Actions Webpack build workflowflowchart TB
trigger_push["push to main"] --> workflow["NodeJS_with_Webpack workflow"]
trigger_pr["pull_request to main"] --> workflow
subgraph workflow
direction TB
job_build["job build on ubuntu-latest (matrix node-version: 18.x, 20.x, 22.x)"]
end
job_build --> step_checkout["actions/checkout@v4"]
step_checkout --> step_setup_node["actions/setup-node@v4 with node-version matrix.node-version"]
step_setup_node --> step_npm_install["run npm install"]
step_npm_install --> step_webpack["run npx webpack"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- Consider using
npm ciinstead ofnpm installin the build step to ensure reproducible installs and faster CI runs, especially for lockfile-based projects. - You can speed up repeated workflow runs by adding a cache step for
~/.npm(usingactions/cache) keyed on the lockfile, beforenpm install. - If your project defines a build script, prefer running
npm run build(and calling webpack from there) instead ofnpx webpackto keep the CI behavior aligned with local development conventions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using `npm ci` instead of `npm install` in the build step to ensure reproducible installs and faster CI runs, especially for lockfile-based projects.
- You can speed up repeated workflow runs by adding a cache step for `~/.npm` (using `actions/cache`) keyed on the lockfile, before `npm install`.
- If your project defines a build script, prefer running `npm run build` (and calling webpack from there) instead of `npx webpack` to keep the CI behavior aligned with local development conventions.
## Individual Comments
### Comment 1
<location path=".github/workflows/webpack.yml" line_range="23" />
<code_context>
+ - name: Use Node.js ${{ matrix.node-version }}
+ uses: actions/setup-node@v4
+ with:
+ node-version: ${{ matrix.node-version }}
+
+ - name: Build
</code_context>
<issue_to_address>
**suggestion (performance):** Enable built‑in npm caching to speed up repeated installs.
You can enable caching in `actions/setup-node` by adding `cache: 'npm'` (and `cache-dependency-path` if `package-lock.json` isn’t in the root) so dependencies aren’t re-downloaded on every run, reducing CI time for this workflow.
Suggested implementation:
```
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: npm
# If your package-lock.json is not in the repo root, set this to its path, e.g. "frontend/package-lock.json"
# cache-dependency-path: package-lock.json
```
If your `package-lock.json` (or `npm-shrinkwrap.json`) is not in the repository root, uncomment and adjust `cache-dependency-path` to point to the correct location so the cache is keyed correctly for your dependencies.
</issue_to_address>
### Comment 2
<location path=".github/workflows/webpack.yml" line_range="27-28" />
<code_context>
+
+ - name: Build
+ run: |
+ npm install
+ npx webpack
</code_context>
<issue_to_address>
**suggestion:** Use `npm ci` (and optionally an npm script) instead of `npm install` + bare `npx webpack`.
In CI, `npm ci` is better suited than `npm install` because it uses the lockfile for reproducible installs and is faster on clean machines. Also consider calling webpack via an npm script (e.g. `npm run build`) so build options live in `package.json` and you don’t depend on `npx` or any global webpack installation.
Suggested implementation:
```
- name: Build
run: |
npm ci
npm run build
```
Ensure that your `package.json` defines a build script, e.g.:
```json
{
"scripts": {
"build": "webpack"
}
}
```
If your build requires specific webpack CLI options, include them in the `"build"` script instead of in the workflow.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+27
to
+28
| npm install | ||
| npx webpack |
There was a problem hiding this comment.
suggestion: Use npm ci (and optionally an npm script) instead of npm install + bare npx webpack.
In CI, npm ci is better suited than npm install because it uses the lockfile for reproducible installs and is faster on clean machines. Also consider calling webpack via an npm script (e.g. npm run build) so build options live in package.json and you don’t depend on npx or any global webpack installation.
Suggested implementation:
- name: Build
run: |
npm ci
npm run build
Ensure that your package.json defines a build script, e.g.:
{
"scripts": {
"build": "webpack"
}
}If your build requires specific webpack CLI options, include them in the "build" script instead of in the workflow.
laith-max
marked this pull request as draft
May 19, 2026 08:19
laith-max
marked this pull request as ready for review
May 19, 2026 08:20
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/webpack.yml">
<violation number="1" location=".github/workflows/webpack.yml:15">
P2: Node 18.x is below the project's minimum engine requirement (`node >= 20.0.0` in package.json). Remove it from the matrix to avoid guaranteed failures or testing against an unsupported runtime.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] |
There was a problem hiding this comment.
P2: Node 18.x is below the project's minimum engine requirement (node >= 20.0.0 in package.json). Remove it from the matrix to avoid guaranteed failures or testing against an unsupported runtime.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/webpack.yml, line 15:
<comment>Node 18.x is below the project's minimum engine requirement (`node >= 20.0.0` in package.json). Remove it from the matrix to avoid guaranteed failures or testing against an unsupported runtime.</comment>
<file context>
@@ -0,0 +1,28 @@
+
+ strategy:
+ matrix:
+ node-version: [18.x, 20.x, 22.x]
+
+ steps:
</file context>
Suggested change
| node-version: [18.x, 20.x, 22.x] | |
| node-version: [20.x, 22.x] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist
Summary by Sourcery
CI: