Skip to content

fix(android): pull to refresh checks the scroll area under the finger; a scrolled side menu scrolls back up instead of refreshing (1.6.1) #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kh0pper merged 1 commit into from
Oct 6, 2026
Merged

fix(android): pull to refresh checks the scroll area under the finger; a scrolled side menu scrolls back up instead of refreshing (1.6.1) #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ android {
// - Meta Wearables DAT SDK (mwdat-*) targets API 34+
minSdk 34
targetSdk 34
versionCode 20
versionName "1.6.0"
versionCode 21
versionName "1.6.1"
}

// VERSION_NAME is exposed via BuildConfig so the WebView UA + appVersion()
Expand Down
15 changes: 13 additions & 2 deletions android/app/src/main/java/press/maestro/crow/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,19 @@ protected void onCreate(Bundle savedInstanceState) {
return false;
}
lastScrollProbeMs = now;
// First the scroll containers under the finger, wherever they are on the page (the
// side menu is outside .content-body: a downward swipe in a scrolled menu used to
// pull to refresh instead of scrolling it back up). Touch coordinates are device
// pixels; elementFromPoint takes CSS pixels.
webView.evaluateJavascript(
"(function() {" +
"(function(x, y) {" +
" var d = window.devicePixelRatio || 1;" +
" for (var el = document.elementFromPoint(x / d, y / d); el && el !== document.documentElement; el = el.parentElement) {" +
" if (el.scrollHeight > el.clientHeight && el.scrollTop > 5) {" +
" var oy = window.getComputedStyle(el).overflowY;" +
" if (oy === 'auto' || oy === 'scroll') return el.scrollTop;" +
" }" +
" }" +
" var all = document.querySelectorAll('.content-body, .content-body *');" +
" for (var i = 0; i < all.length; i++) {" +
" var el = all[i];" +
Expand All @@ -230,7 +241,7 @@ protected void onCreate(Bundle savedInstanceState) {
" }" +
" }" +
" return window.scrollY || document.documentElement.scrollTop || 0;" +
"})()",
"})(" + event.getX() + ", " + event.getY() + ")",
value -> {
try {
double scrollTop = Double.parseDouble(value);
Expand Down
Loading