Repository navigation
fix(android): pull to refresh checks the scroll area under the finger; a scrolled side menu scrolls back up instead of refreshing (1.6.1) - #449
Merged
Conversation
…, so a downward swipe in a scrolled side menu scrolls it instead of refreshing the page (1.6.1)
kh0pper
force-pushed
the
fix/android-menu-pull-refresh
branch
from
October 6, 2026 18:28
2a0048e to
8866246
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With the side menu open and scrolled down, a downward swipe in the menu refreshed the page instead of scrolling the menu back up. The pull-to-refresh guard only looked for scrolled containers inside
.content-body; the menu is outside it, so with the page itself at the top the guard reported "at top" and the swipe became a refresh.What changes
On touch-down, the scroll probe first walks the element under the finger and its ancestors (any
overflow-y: auto | scrollcontainer scrolled down by more than 5 px blocks the refresh), then runs the existing.content-bodywalk and page-scroll check unchanged. Touch coordinates are converted from device pixels to CSS pixels withdevicePixelRatio. App version 1.6.1 (versionCode 21).Tests
The app compiles and a signed release build succeeds. The behaviour was checked by reading the guard; it needs a check on a phone (open the menu, scroll it down, swipe down: the menu scrolls up; at the menu's top, a swipe down still refreshes).