Repository navigation
feat(counts): a location can turn Counts off - #541
Merged
Merged
Conversation
ibrahimroshdy
force-pushed
the
feat/counts-can-be-turned-off
branch
from
November 13, 2026 00:11
4163634 to
2377dcb
Compare
ibrahimroshdy
added a commit
that referenced
this pull request
Nov 13, 2026
Review of #541 (#506): - an export names a location's modules from its switch rows, and existing locations had none for Counts, so an import turned Counts off. 0177 now gives every location its Counts row, on; an export also names the modules it knew (modulesKnown), and an import sets only those, so one made before Counts leaves the target's own switch as it is; - Check this kit shows only while Counts is on; - with Counts off the Counts list (server, mock and app) lists the box checks only, with a line saying so, and a box check's Back lands on its location's list; a count's page says Counts are off instead of an error; /counts opens on a location with Counts on; - a planned count with Counts off can be paused, resumed or deleted, but not done, snoozed or skipped (409 module_off; tool_unavailable through MCP and the assistant), and its row offers none of those; - docs: Turning Counts off and the kits line in every language, and the es and it wording for planned counts. Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
Two strings for a place with Counts turned off everywhere (#506): the Counts list and Start a session say so, and who can turn them back on. Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
Counts is now a module, like Labels and Lending, for a location that doesn't count. It is in every preset, so every location keeps its counts until an owner or admin turns it off in What to track; nothing is deleted. Off in a location: - the place page has no Count here, Count regularly or Past counts; boxes no Count this box; the map's room card no Count this room; Start a session no count there; the location page no Counts link; Tools hides Counts once it is off everywhere, and the Counts list says so; - the counts' reads are 404 module_off and writes 409 (the list, a count's page, its CSV, its lines, the open-count lookup, starting a count); a count saved on a phone meanwhile is dropped; a planned count can't be made or changed, and leaves the agenda, so it reminds no one; - packs, moves and box checks are unchanged. Migration 0177 is additive: kept.module_enabled() gains counts in every preset and the agenda view filters planned counts by it. Docs: Modules and presets, Counts and stocktakes, features, README. Fixes #506 Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
One string for a location with Counts off, whose Counts list shows its box checks only (#506). Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
Review of #541 (#506): - an export names a location's modules from its switch rows, and existing locations had none for Counts, so an import turned Counts off. 0177 now gives every location its Counts row, on; an export also names the modules it knew (modulesKnown), and an import sets only those, so one made before Counts leaves the target's own switch as it is; - Check this kit shows only while Counts is on; - with Counts off the Counts list (server, mock and app) lists the box checks only, with a line saying so, and a box check's Back lands on its location's list; a count's page says Counts are off instead of an error; /counts opens on a location with Counts on; - a planned count with Counts off can be paused, resumed or deleted, but not done, snoozed or skipped (409 module_off; tool_unavailable through MCP and the assistant), and its row offers none of those; - docs: Turning Counts off and the kits line in every language, and the es and it wording for planned counts. Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
ibrahimroshdy
force-pushed
the
feat/counts-can-be-turned-off
branch
from
November 13, 2026 00:59
2377dcb to
d5606aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counts can be turned off for a location, like Labels and Lending.
Closes #506.
countsjoins the modules and is on in every preset, so existing locations are unchanged.CREATE OR REPLACEonly):kept.module_enabled()knowscounts, and the agenda leaves planned counts out while Counts is off, so they stop reminding.module_off; starting a count or creating or editing a planned count answers 409; the phone's count sync operations are dropped. Packs, moves and box checks are unaffected.upcomingreads the agenda, so it follows.Decisions in this PR
Definition of done
sessions/counts-module.test.ts(4) andscreens/counts-module.test.tsx(6), three cases insession-screen.test.tsx,modules.test.ts,locations.test.ts,tours.test.ts, each seen failing first. Server suite green apart from the Mailpit tests that need a local Mailpit. Fast gate green.KEPT_*settings: n/a.