Skip to content

fix: upgrade sandboxes-service-api-client to ^2.1.1 (drop required provisioningStrategy) - #107

Merged
odinuv merged 1 commit into
mainfrom
devin/1785752196-fix-ownerless-workspaces-provisioning-strategy
Aug 3, 2026
Merged

fix: upgrade sandboxes-service-api-client to ^2.1.1 (drop required provisioningStrategy)#107
odinuv merged 1 commit into
mainfrom
devin/1785752196-fix-ownerless-workspaces-provisioning-strategy

Conversation

@OlenaMarchuk

Copy link
Copy Markdown
Contributor

Changes:

  • Bump keboola/sandboxes-service-api-client ^1.8.0^2.1.1 (pulls in new keboola/php-api-client-base 1.1.2).
  • Adapt the changed AppsApiClient constructor in DeleteOwnerlessWorkspaces and DeleteOrganizationOwnerlessWorkspaces — v2 dropped the ApiClientConfiguration wrapper, so args are now passed directly (new AppsApiClient(baseUrl:, storageToken:, userAgent:)).

Why

storage:delete-ownerless-workspaces crashed at App.php:79 with Property provisioningStrategy is missing from API response. The 1.8.0 App model listed provisioningStrategy as a required property, but the sandboxes service (e.g. eu-central-1.keboola.com) doesn't return it, so App::fromArray() threw as soon as listApps() tried to hydrate any Python/R sandbox. Client v2.1.0 removed provisioningStrategy from REQUIRED_PROPERTIES (and the field), fixing the mismatch.

Lock file changes are minimal (only the target package + its new base dependency; guzzle kept pinned). phpcs, phpstan (level 9) and phpunit all pass locally.


Additional notes

⚠️ Don't forget to release new version after merge

Link to Devin session: https://app.devin.ai/sessions/f90cad9ed68f4732b8bac0a66a3b358b
Requested by: @OlenaMarchuk

…ovisioningStrategy)

Co-Authored-By: olena.marchuk <olena.marchuk@keboola.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot requested a review from odinuv August 3, 2026 10:23
@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review August 3, 2026 10:24
@devin-ai-integration
devin-ai-integration Bot requested review from jirkasemmler and removed request for odinuv August 3, 2026 12:25
@jirkasemmler
jirkasemmler requested a review from odinuv August 3, 2026 13:12
@odinuv
odinuv merged commit e5d965d into main Aug 3, 2026
1 check passed
@odinuv
odinuv deleted the devin/1785752196-fix-ownerless-workspaces-provisioning-strategy branch August 3, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants