Skip to content

fix: tolerate already-deleted configs during ownerless workspace cleanup - #110

Merged
jirkasemmler merged 1 commit into
mainfrom
devin/1785928471-handle-already-deleted-config-in-ownerless-cleanup
Aug 5, 2026
Merged

fix: tolerate already-deleted configs during ownerless workspace cleanup#110
jirkasemmler merged 1 commit into
mainfrom
devin/1785928471-handle-already-deleted-config-in-ownerless-cleanup

Conversation

@OlenaMarchuk

Copy link
Copy Markdown
Contributor

Changes:

  • Handle storage.configuration.notFound (404) the same way as storage.components.cannotDeleteConfiguration when purging a workspace's configuration in DeleteOwnerlessWorkspaces and DeleteOrganizationOwnerlessWorkspaces (both the editor-session path and the sandbox fallback path).

Why

After #107 fixed the provisioningStrategy crash, storage:delete-ownerless-workspaces --force still aborted on the first workspace:

In Client.php line 2972:
  Configuration "01k7h1gm62awbpdk0nmtwddgte" not found
... 404 Not Found ... "code":"storage.configuration.notFound"

Dry-run only lists sessions, so it succeeded; --force actually calls deleteConfiguration. An editor session can outlive its configuration (config already trashed/purged elsewhere), so deleteConfiguration throws storage.configuration.notFound. The catch only tolerated storage.components.cannotDeleteConfiguration, so the 404 escaped and killed the whole run.

Now both codes are treated as "config already gone / can't be purged":

  • editor-session path: still deletes the lingering editor session and continues;
  • sandbox fallback path: nothing left to do, continues.

Any other StorageClientException still re-throws. phpcs, phpstan (level 9) and phpunit pass locally.


Additional notes

⚠️ Don't forget to release new version after merge

Link to Devin session: https://app.devin.ai/sessions/f90cad9ed68f4732b8bac0a66a3b358b
Requested by: @OlenaMarchuk

…) during ownerless workspace cleanup

Co-Authored-By: olena.marchuk <olena.marchuk@keboola.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review August 5, 2026 11:17
@jirkasemmler
jirkasemmler merged commit 241f3bb into main Aug 5, 2026
1 check passed
@jirkasemmler
jirkasemmler deleted the devin/1785928471-handle-already-deleted-config-in-ownerless-cleanup branch August 5, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants