fix: tolerate already-deleted configs during ownerless workspace cleanup - #110
Merged
jirkasemmler merged 1 commit intoAug 5, 2026
Conversation
…) during ownerless workspace cleanup Co-Authored-By: olena.marchuk <olena.marchuk@keboola.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
jirkasemmler
approved these changes
Aug 5, 2026
jirkasemmler
deleted the
devin/1785928471-handle-already-deleted-config-in-ownerless-cleanup
branch
August 5, 2026 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
storage.configuration.notFound(404) the same way asstorage.components.cannotDeleteConfigurationwhen purging a workspace's configuration inDeleteOwnerlessWorkspacesandDeleteOrganizationOwnerlessWorkspaces(both the editor-session path and the sandbox fallback path).Why
After #107 fixed the
provisioningStrategycrash,storage:delete-ownerless-workspaces --forcestill aborted on the first workspace:Dry-run only lists sessions, so it succeeded;
--forceactually callsdeleteConfiguration. An editor session can outlive its configuration (config already trashed/purged elsewhere), sodeleteConfigurationthrowsstorage.configuration.notFound. Thecatchonly toleratedstorage.components.cannotDeleteConfiguration, so the 404 escaped and killed the whole run.Now both codes are treated as "config already gone / can't be purged":
Any other
StorageClientExceptionstill re-throws.phpcs,phpstan(level 9) andphpunitpass locally.Additional notes
Link to Devin session: https://app.devin.ai/sessions/f90cad9ed68f4732b8bac0a66a3b358b
Requested by: @OlenaMarchuk