Add Sandwiching#130
Conversation
|
Not sure how properly I implemented the extension |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 98.71% 98.72% +0.01%
==========================================
Files 10 12 +2
Lines 1011 1101 +90
==========================================
+ Hits 998 1087 +89
- Misses 13 14 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I want to make some changes, but I'm flying home so will do later in the week. I think we should move more of the code to the extension. |
|
Ready for me to take another look? |
|
I think we need to change |
|
A couple of things:
I wanted to point these things out in order to make sure that the tests we perform are solid and robust. |
|
It's okay to solve some points before checking the time limit, so that even if time limit is 0 we still return with > 0 points. There's a |
odow
left a comment
There was a problem hiding this comment.
There are things we can tweak but this is good enough for now
Early working prototype we can call this one.
Followed this one: https://repository.tilburguniversity.edu/server/api/core/bitstreams/32798533-bd45-4241-8ad3-f7c34a8bb3ac/content