Skip to content

Reject unknown user actions instead of silently returning 200 #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mehdi-shokohi wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −0
Open

Reject unknown user actions instead of silently returning 200 #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cmd/api/handlers/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,13 @@ func (h *HandlersApi) UserActionHandler(w http.ResponseWriter, r *http.Request)
}
}
returnData = "user removed successfully"
default:
// Reject unknown actions explicitly. Without this case an
// unrecognized action (e.g. "update") matches nothing, skips all
// branches, and still returns 200 with an empty payload — a silent
// no-op that looks like success while creating/editing nothing.
apiErrorResponse(w, "invalid action", http.StatusBadRequest, fmt.Errorf("unknown user action %q", actionVar))
return
}
// Serialize and serve JSON
log.Debug().Msgf("Returned [%s]", returnData)
Expand Down