Reject unknown user actions instead of silently returning 200 - #1015
Open
mehdi-shokohi wants to merge 1 commit into
Open
Reject unknown user actions instead of silently returning 200#1015mehdi-shokohi wants to merge 1 commit into
mehdi-shokohi wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the PR! I can amend the signature, but in the future, please do sign your commits. Thanks again! |
Collaborator
|
Actually I can not amend it, since it comes from your fork. Can you sign the commit please? Thanks! |
javuto
approved these changes
Sep 3, 2026
javuto
requested changes
Sep 4, 2026
javuto
left a comment
javuto
left a comment
Collaborator
There was a problem hiding this comment.
Please sign the commit, thanks!
javuto
requested changes
Sep 5, 2026
javuto
left a comment
javuto
left a comment
Collaborator
There was a problem hiding this comment.
Please sign the commit to be able to merge, thanks!
UserActionHandler switches on the {action} path segment but had no
default case. An unrecognized action (e.g. "update") matched none of
add/edit/remove, skipped every branch, and still fell through to the
trailing HTTPResponse — returning 200 {"data":""} while creating,
editing, or removing nothing. Callers reasonably read the 200 as
success, so a typo'd action silently no-ops.
Add a default case that returns 400 "invalid action".
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mehdi-shokohi
force-pushed
the
fix/user-action-unknown-default
branch
from
September 5, 2026 21:35
ba7d605 to
bc77368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserActionHandler switches on the {action} path segment but had no default case. An unrecognized action (e.g. "update") matched none of add/edit/remove, skipped every branch, and still fell through to the trailing HTTPResponse — returning 200 {"data":""} while creating, editing, or removing nothing. Callers reasonably read the 200 as success, so a typo'd action silently no-ops.
Add a default case that returns 400 "invalid action".