Skip to content

Forward legacy options from String extension #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Forward legacy options from String extension #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dfcd5b
Forward legacy options from String extension
OskarEichler Aug 30, 2026
0f7cedc
Cover legacy String option forwarding
OskarEichler Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/unicode/display_width/string_ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

class String
def display_width(ambiguous = nil, overwrite = nil, old_options = {}, **options)
Unicode::DisplayWidth.of(self, ambiguous, overwrite, old_options = {}, **options)
Unicode::DisplayWidth.of(self, ambiguous, overwrite, old_options, **options)
end
end
7 changes: 7 additions & 0 deletions spec/display_width_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
require_relative '../lib/unicode/display_width/string_ext'

describe 'Unicode::DisplayWidth.of' do
it 'forwards positional legacy options from String with the same precedence as .of' do
expect( '·'.display_width(nil, nil, { ambiguous: 2 }) ).to eq 2
expect( '·'.display_width(nil, nil, { ambiguous: 2 }, ambiguous: 1) ).to eq(
Unicode::DisplayWidth.of('·', nil, nil, { ambiguous: 2 }, ambiguous: 1)
)
end

describe '[east asian width]' do
it 'returns 2 for F' do
expect( '！'.display_width ).to eq 2
Expand Down
Loading