Repository navigation
Forward legacy options from String extension - #35
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
Owner
|
Can you please add a test-case illustrating the option passing bug + fix? |
Contributor
Author
|
Added the requested regression in 0f7cedc: a positional legacy ambiguous-width option reaches String#display_width, and mixed positional/keyword options preserve the existing .of precedence. Full suite: 68 examples, zero failures on Ruby 4.0.6; git diff --check passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String#display_widthcurrently replaces its supplied legacy options hash with a fresh empty hash before delegating, so the compatibility argument is silently ignored. Forward the received value unchanged.Verified with the full 67-example suite and a focused legacy-options model on Ruby 4.0.6 and 3.2.11.