Skip to content

test: Skip block reason checks for an unrecovered sender #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chfast merged 1 commit into from
Aug 10, 2026
+198 −11
Merged

test: Skip block reason checks for an unrecovered sender #1632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions test/blockchaintest/blockchaintest_runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,11 +373,14 @@ void run_blockchain_tests(std::span<const BlockchainTest> tests, evmc::VM& vm)
}
if (res.requests_error)
{
// Requests collection failure; verify the reason the same way.
EXPECT_TRUE(is_expected_block_exception(
res.requests_error, test_block.expected_exception))
<< "Block invalidity reason mismatch: got " << res.requests_error.message()
<< ", expected " << test_block.expected_exception;
if (!sender_not_recovered)
{
EXPECT_TRUE(is_expected_block_exception(
res.requests_error, test_block.expected_exception))
<< "Block invalidity reason mismatch: got "
<< res.requests_error.message() << ", expected "
<< test_block.expected_exception;
}
continue;
}
// The block executed, so it is invalid only if it computes something other than
Expand All @@ -392,7 +395,7 @@ void run_blockchain_tests(std::span<const BlockchainTest> tests, evmc::VM& vm)
// Asserts the fixture names one of @p names, the exceptions the check that just
// fired is the symptom of. Silent where the reason cannot be compared.
const auto expect_fixture_names = [&](std::string_view names) {
if (!names_spec_exception || ommers_not_validated)
if (!names_spec_exception || ommers_not_validated || sender_not_recovered)
Comment thread
chfast marked this conversation as resolved.
return;
EXPECT_TRUE(contains_any(test_block.expected_exception, names))
<< "Block invalidity reason mismatch: the block failed the check for "
Expand All @@ -410,11 +413,7 @@ void run_blockchain_tests(std::span<const BlockchainTest> tests, evmc::VM& vm)

if (state::mpt_hash(res.block_state) != test_block.expected_block_header.state_root)
{
// The state root is also where a sender that was not recovered surfaces,
// see the TODO above.
expect_fixture_names(
"BlockException.INVALID_STATE_ROOT|"
"TransactionException.INVALID_SIGNATURE_VRS");
expect_fixture_names("BlockException.INVALID_STATE_ROOT");
continue;
}

Expand Down
10 changes: 10 additions & 0 deletions test/integration/blockchaintest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,15 @@ add_test(
COMMAND evmone-blockchaintest ${TESTS1}/eip7778_block_gas.json
)

# A block invalid by its signature must not be judged by another check.
add_test(
NAME ${PREFIX}/unrecovered_sender_blob_gas
COMMAND evmone-blockchaintest ${TESTS1}/unrecovered_sender_blob_gas.json
)
add_test(
NAME ${PREFIX}/unrecovered_sender_deposit_log
COMMAND evmone-blockchaintest ${TESTS1}/unrecovered_sender_deposit_log.json
)

get_directory_property(ALL_TESTS TESTS)
set_tests_properties(${ALL_TESTS} PROPERTIES ENVIRONMENT LLVM_PROFILE_FILE=${CMAKE_BINARY_DIR}/integration-%p.profraw)
86 changes: 86 additions & 0 deletions test/integration/blockchaintest/unrecovered_sender_blob_gas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
{
"unrecovered_sender_blob_gas": {
"_info": {
"comment": "The runner takes the sender from the fixture, so it cannot see the broken signature; the transaction executes and the wrong blobGasUsed is the first header mismatch."
},
"network": "Cancun",
"genesisBlockHeader": {
"parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
"coinbase": "0x0000000000000000000000000000000000000000",
"stateRoot": "0x0000000000000000000000000000000000000000000000000000000000000000",
"transactionsTrie": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
"receiptTrie": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
"bloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"number": "0x00",
"gasLimit": "0x01000000",
"gasUsed": "0x00",
"timestamp": "0x00",
"extraData": "0x00",
"baseFeePerGas": "0x10",
"withdrawalsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
"blobGasUsed": "0x00",
"excessBlobGas": "0x00",
"hash": "0x0000000000000000000000000000000000000000000000000000000000000001"
},
"pre": {
"0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
"code": "0x",
"nonce": "0x00",
"balance": "0x02540be400"
}
},
"blocks": [
{
"expectException": "TransactionException.INVALID_SIGNATURE_VRS",
"rlp": "0x",
"rlp_decoded": {
"blockHeader": {
"parentHash": "0x0000000000000000000000000000000000000000000000000000000000000001",
"coinbase": "0x000000000000000000000000000000000000c014",
"stateRoot": "0x0000000000000000000000000000000000000000000000000000000000000000",
"transactionsTrie": "0x0000000000000000000000000000000000000000000000000000000000000000",
"receiptTrie": "0x0000000000000000000000000000000000000000000000000000000000000000",
"bloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"number": "0x01",
"gasLimit": "0x01000000",
"gasUsed": "0x00",
"timestamp": "0x0c",
"extraData": "0x",
"baseFeePerGas": "0x0e",
"blobGasUsed": "0x00",
"excessBlobGas": "0x00",
"hash": "0x0000000000000000000000000000000000000000000000000000000000000002"
},
"transactions": [
{
"type": "0x03",
"nonce": "0x00",
"to": "0x000000000000000000000000000000000000c0de",
"value": "0x00",
"input": "0x",
"gasLimit": "0x186a0",
"maxFeePerGas": "0x0e",
"maxPriorityFeePerGas": "0x00",
"maxFeePerBlobGas": "0x01",
"blobVersionedHashes": [
"0x0100000000000000000000000000000000000000000000000000000000000001"
],
"v": "0x00",
"r": "0x00",
"s": "0x01",
"sender": "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b"
}
]
}
}
],
"lastblockhash": "0x0000000000000000000000000000000000000000000000000000000000000001",
"postState": {
"0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
"code": "0x",
"nonce": "0x00",
"balance": "0x02540be400"
}
}
}
}
92 changes: 92 additions & 0 deletions test/integration/blockchaintest/unrecovered_sender_deposit_log.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
{
"unrecovered_sender_deposit_log": {
"_info": {
"comment": "As above, but the block reaches the requests check: the executed transaction makes the deposit contract emit a log with no data."
},
"network": "Prague",
"genesisBlockHeader": {
"parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
"coinbase": "0x0000000000000000000000000000000000000000",
"stateRoot": "0x0000000000000000000000000000000000000000000000000000000000000000",
"transactionsTrie": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
"receiptTrie": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
"bloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"number": "0x00",
"gasLimit": "0x01000000",
"gasUsed": "0x00",
"timestamp": "0x00",
"extraData": "0x00",
"baseFeePerGas": "0x10",
"withdrawalsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
"blobGasUsed": "0x00",
"excessBlobGas": "0x00",
"hash": "0x0000000000000000000000000000000000000000000000000000000000000001"
},
"pre": {
"0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
"code": "0x",
"nonce": "0x00",
"balance": "0x02540be400"
},
"0x00000000219ab540356cbb839cbe05303d7705fa": {
"code": "0x7f649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c560006000a1",
"nonce": "0x01",
"balance": "0x00"
}
},
"blocks": [
{
"expectException": "TransactionException.INVALID_SIGNATURE_VRS",
"rlp": "0x",
"rlp_decoded": {
"blockHeader": {
"parentHash": "0x0000000000000000000000000000000000000000000000000000000000000001",
"coinbase": "0x000000000000000000000000000000000000c014",
"stateRoot": "0x0000000000000000000000000000000000000000000000000000000000000000",
"transactionsTrie": "0x0000000000000000000000000000000000000000000000000000000000000000",
"receiptTrie": "0x0000000000000000000000000000000000000000000000000000000000000000",
"bloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"number": "0x01",
"gasLimit": "0x01000000",
"gasUsed": "0x00",
"timestamp": "0x0c",
"extraData": "0x",
"baseFeePerGas": "0x0e",
"blobGasUsed": "0x00",
"excessBlobGas": "0x00",
"hash": "0x0000000000000000000000000000000000000000000000000000000000000002"
},
"transactions": [
{
"type": "0x02",
"nonce": "0x00",
"to": "0x00000000219ab540356cbb839cbe05303d7705fa",
"value": "0x00",
"input": "0x",
"gasLimit": "0x186a0",
"maxFeePerGas": "0x0e",
"maxPriorityFeePerGas": "0x00",
"v": "0x00",
"r": "0x00",
"s": "0x01",
"sender": "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b"
}
]
}
}
],
"lastblockhash": "0x0000000000000000000000000000000000000000000000000000000000000001",
"postState": {
"0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
"code": "0x",
"nonce": "0x00",
"balance": "0x02540be400"
},
"0x00000000219ab540356cbb839cbe05303d7705fa": {
"code": "0x7f649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c560006000a1",
"nonce": "0x01",
"balance": "0x00"
}
}
}
}