test: Skip block reason checks for an unrecovered sender - #1632
Merged
Conversation
chfast
force-pushed
the
test/blockchain-runner-cleanup
branch
from
August 10, 2026 17:14
e60331c to
7feee83
Compare
chfast
force-pushed
the
test/blockchain-runner-cleanup
branch
from
August 10, 2026 17:25
7feee83 to
04e520a
Compare
chfast
force-pushed
the
test/blockchain-runner-cleanup
branch
from
August 10, 2026 17:34
04e520a to
dca6f4e
Compare
chfast
force-pushed
the
test/blockchain-runner-cleanup
branch
2 times, most recently
from
August 10, 2026 17:47
6c1c8d1 to
991d7e5
Compare
There was a problem hiding this comment.
Pull request overview
Extends #1623’s invalidity-reason checks to account for transaction senders that cannot be recovered.
Changes:
- Skips header-reason comparisons for unrecovered senders.
- Adds a Cancun blob-gas regression fixture and CTest entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/blockchaintest/blockchaintest_runner.cpp |
Adjusts invalidity-reason matching. |
test/integration/blockchaintest/unrecovered_sender_blob_gas.json |
Adds regression fixture. |
test/integration/blockchaintest/CMakeLists.txt |
Registers the regression test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1632 +/- ##
=======================================
Coverage 97.70% 97.71%
=======================================
Files 171 171
Lines 15593 15593
Branches 3606 3607 +1
=======================================
+ Hits 15235 15236 +1
Misses 269 269
+ Partials 89 88 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The gap was patched only in the state-root check's names, but the requests and blob-gas checks run before it, so a block whose bad signature the runner cannot see was judged against a rule it does not break. Skip those checks too, as for the unvalidated ommer headers.
chfast
force-pushed
the
test/blockchain-runner-cleanup
branch
from
August 10, 2026 18:09
991d7e5 to
6f26198
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1623. The unrecovered-sender gap was patched only in the state-root check's names, but the blob-gas check runs before it, so a block whose bad signature the runner cannot see was judged against a rule it does not break. Skip the whole ladder instead, as already done for the unvalidated ommer headers.
No existing fixture reaches that path, so the regression test is a new one: a Cancun block carrying a blob transaction with a broken signature and a
blobGasUsedthe execution contradicts. Without the fix it reports