Repository navigation
Ship the trace plugin in the wheel; accuracy.py fails on zero scored - #165
Merged
Merged
Conversation
- verify failed after `pip install testgraph`: the wheel shipped testgraph/ only and the tgtrace plugin lives in harness/plugin/. force-include copies that one file to testgraph/_plugin/; plugin_dir checks the packaged copy first, then the checkout. - harness/accuracy.py printed S1 VERDICT : PASS when every commit failed to check out or index (min_recall starts at 1.0 and error rows continue past it). Fail when nothing was scored or any row errored or was BLOCKED (#97). Closes #97
#165 review: - `uv build` builds the wheel from the sdist, which had no harness/, so the force-include failed and the release would not build. The sdist now includes harness/plugin/tgtrace.py, and a CI `build` job runs the same `uv build` and checks the wheel for the plugin. - One PLUGIN_MISSING message for verify and the adapter, naming both the installed and the checkout location. - accuracy.py prints MIN RECALL n/a when nothing was scored. - USAGE/README/pyproject wording; .gitignore testgraph/_plugin/.
#165 round 2: - plugin_dir checks harness/plugin before testgraph/_plugin, so a stray packaged copy in a checkout cannot shadow the file being edited (the .gitignore entry from the last commit only hid it; reverted). - Test that every wheel force-include source is in the sdist include, so the B1 regression fails locally, not only in the CI build job. - Test the MIN RECALL n/a line. - Remaining "wheel ships testgraph/ alone" wording (README, registry, test_registries) and a pyproject comment pointing the wrong way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from the 2026-11-12 audit.
1.
verifyfailed afterpip install testgraphThe wheel shipped
testgraph/only, andverifyneedsharness/plugin/tgtrace.pyat runtime.[tool.hatch.build.targets.wheel.force-include]now copies that one file totestgraph/_plugin/tgtrace.py.harness/still ships nothing else, so the "no import contract" packaging decision holds, andharness/plugin/stays the source of truth.plugin_dir()checks the packaged copy first, then the checkout.From an installed wheel, run from outside any checkout (
python -I), against this repo with--dry-run --base HEAD~3:(exit 3 is the expected honest refusal, the same result a checkout gives.)
2.
harness/accuracy.pyprintedS1 VERDICT : PASSon a run that scored nothing (#97)min_recallstarts at 1.0 and WORKTREE-FAIL / INDEX-FAIL / BLOCKED rowscontinuepast it. Now it fails when no commit was scored or any row errored or was BLOCKED (the same barseed_regressions.pyuses), and printscommits scored: N / M.Verification
accuracy.py:FAILED (failures=2)(3 tests)TG_REQUIRE_PYTEST=1:Ran 569 tests in 35.972s/OKuv build --wheelliststestgraph/_plugin/tgtrace.pyCloses #97