Skip to content

plugin_dir / packaging follow-ups from #165 review #166

Open

Description

@inth3shadows

Low-severity leftovers from the #165 review (rounds 2-3). Related: #122, #163. None blocks the release build; CI's build job covers the main risk.

  • plugin_dir checks <site-packages>/harness/plugin/tgtrace.py before _plugin (testgraph/pytest_adapter.py ~256). An unrelated top-level harness distribution shipping plugin/tgtrace.py, or a pip install --target dir with a harness/ tree, would win. Reproduced only by planting the file. Tighter: require a checkout marker (pyproject.toml / .git) beside harness/.
  • plugin_dir(start=...) is dead and a trap: no caller passes it, and with start set the packaged _plugin is never consulted. Drop it, or document it and fall back.
  • test_the_sdist_carries_every_file_the_wheel_force_includes is a string-prefix proxy: it ignores hatch globs, the sdist exclude and VCS-ignore filtering. An exclude = ["harness"] would pass it while breaking the build; only CI uv build catches that.
  • Pre-existing: the sdist include pattern README.md also pulls in harness/fixtures/dyndemo/README.md.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions