Skip to content

Stop restarting benchmarks on PR metadata edits #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludfjig wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop restarting benchmarks on PR metadata edits #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark-policy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Benchmark Policy
on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened, labeled, unlabeled, edited]
types: [opened, synchronize, reopened, labeled, unlabeled]

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/benchmark-trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
branches: [main]
pull_request:
branches: [main]
types: [opened, synchronize, reopened, labeled, unlabeled, edited, ready_for_review]
types: [opened, synchronize, reopened, labeled, unlabeled]

permissions:
contents: read
Expand Down
4 changes: 2 additions & 2 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ Pages skips a preview whose build lacks `index.html`, contains symbolic links, h
## CI Rules

* `benchmarks: skip` replaces publishable measurements with one-request smoke coverage on KVM and MSHV. Smoke results are not published. Dependabot applies the label automatically.
* Required checks evaluate the current PR policy on every subscribed event. Label and description edits restart the benchmark workflow. Measurements run unless `benchmarks: skip` is present.
* Benchmark Policy and Benchmark run when a PR opens, reopens, gets new commits or changes labels. Any label change restarts measurement. Measurements run unless `benchmarks: skip` is present.
* A PR retargeted to `main` needs a new push before its required checks run.
* Each of the 36 measurement jobs runs all three strategies sequentially with a fresh server process for each. Retrying a job repeats its three strategies.
* Preview builds run independently of benchmarks. Draft PRs have no preview.
* Production uses published history. Previews include matching pending results when available.
Expand All @@ -119,7 +120,6 @@ after a direct push to `data`. The deploy job fails if the site still serves an
older deployment after 5 minutes. Rerun the deploy job.

Publication and Pages use serial queues with up to 100 pending jobs or runs each.
Benchmark checks ignore unrelated labels and title or body edits.

## Security

Expand Down
Loading