Repository navigation
Conversation
Benchmark and Benchmark Policy ran on edited and ready_for_review events. Editing a PR description or marking a draft ready restarted all 36 measurement jobs and cancelled any measurement in progress, though neither changes the head, base or skip label that eligibility reads. Both workflows now run only when a PR opens, reopens, gets new commits or changes labels. A PR retargeted to main runs its checks on its next push. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a PR description or marking a draft ready restarted all 36 benchmark measurement jobs. Neither changes what eligibility reads, which is the head, the base and the
benchmarks: skiplabel. #46 lost a passing run this way.editedorready_for_review.benchmarks: skipchanges what runs.To test: after the smoke run passes, edit this description. Neither workflow should start.