Repository navigation
feat(datasets): delete episodes from a local dataset - #143
Draft
ravediamond wants to merge 2 commits into
Draft
ravediamond wants to merge 2 commits into
ravediamond wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #142; only the last commit (
feat(datasets): delete episodes from a local dataset) is new. Draft until #142 lands, then I'll rebase.Problem
#142 lets you set bad takes aside by moving them into a new dataset. When a take is plainly unusable (arm out of frame, recording started too early), keeping a copy just leaves a dataset to clean up by hand later.
Approach
A "Delete episodes" button next to "Move episodes". It opens the same dialog (renamed
EpisodesDialog, with amode), without the name field and with a red button. The text says the episodes are removed for good and points to Move to keep a copy.POST /datasets/delete-episodesruns LeRobot'sdelete_episodesinto a staging dir and swaps it in for the source, so a failure leaves the source untouched. The episodes left are renumbered._load_for_episode_edit,_swap_in_staged_copy): 409 while recording, 422 for empty or negative indices, 400 for out-of-range indices or deleting every episode.If this is one button too many for the browser, I'm happy to drop it and keep only move.
Testing
npm run build,pre-commit run --all-files.Tested on Linux (Jetson Orin, aarch64) only. Not tested on macOS, Windows, or a real SO-101 dataset.