Repository navigation
feat(cameras): ghost overlay of a saved reference frame to realign the rig - #139
Open
ravediamond wants to merge 1 commit into
Open
ravediamond wants to merge 1 commit into
ravediamond wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138
If you stash the arm and cameras between sessions, putting the framing back by eye is unreliable, and framing that drifts between episodes hurts policy training. The arm is in view, so one reference frame per camera captures both camera framing and arm pose.
In the recording dialog, each camera now has a Set reference button. It saves the frame currently shown in the preview. After that the reference is drawn as a translucent ghost over the live preview, with a slider for its opacity, so you can nudge the rig until the two line up. Clear removes it.
How it works:
GET/PUT/DELETE /robots/{name}/camera-reference/{camera}, saved under~/.cache/huggingface/lerobot/camera_references/<robot>/<camera>.png. Names go through the same check as robot names, and the body must be a PNG under 10 MB.Left out on purpose to keep this small: an alignment score and lighting match. They're in the standalone tool this came from (https://github.com/ravediamond/teleop-setup-align) and could follow if this is useful.