Repository navigation
feat(admin): notes on a notepad sheet next to Edit (Admins, Users) - #107
Open
Hiddify-Official wants to merge 1 commit into
Open
Hiddify-Official wants to merge 1 commit into
Hiddify-Official wants to merge 1 commit into
Conversation
This was referenced Oct 24, 2026
Contributor
|
فکر میکنم اگر روی خود متن نوت بزنیم و اینجوری باز بشه بهتره تا اینکه یک دکمه دیگه به UI اضافه کنیم |
Hiddify-Official
force-pushed
the
feat/note-popover
branch
from
October 27, 2026 21:51
b515c16 to
97d5997
Compare
A notebook button before Edit, only on rows with a note, opens the note on a small pale-yellow ruled sheet. The Admins page loses its Note column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hiddify-Official
force-pushed
the
feat/note-popover
branch
from
October 27, 2026 21:53
97d5997 to
22b6b54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Admins page the note takes a whole column, empty ("—") for most rows, and long notes are cut to two lines. On the Users page a note shows only as a one-line excerpt next to the name. Neither page has a way to read a full, multi-line note without opening the edit form.
Change
shared/components/NoteButton.vue:pi-book), rendered only when the row has a note;AdminsView.vue: the Note column is removed; the button sits before Edit (and on your own row before the configs button).UsersView.vue:Screenshots
Tested
html[dir='rtl'] .note-sheet. An earlier push used:global([dir='rtl']) .note-sheet, which compiles to a bare[dir="rtl"]rule and put the sheet's padding and ruled background on the whole page in Persian. That is fixed here; the page and the sheet were checked in Persian at phone width.vue-tscadds no errors.Review
Rebased on dev after #108 was merged.
🤖 Generated with Claude Code