Skip to content

feat(admin): notes on a notepad sheet next to Edit (Admins, Users) - #107

Open
Hiddify-Official wants to merge 1 commit into
hiddify:devfrom
Hiddify-Official:feat/note-popover
Open

Hiddify-Official wants to merge 1 commit into
hiddify:devfrom
Hiddify-Official:feat/note-popover

Conversation

@Hiddify-Official

@Hiddify-Official Hiddify-Official commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Problem

On the Admins page the note takes a whole column, empty ("—") for most rows, and long notes are cut to two lines. On the Users page a note shows only as a one-line excerpt next to the name. Neither page has a way to read a full, multi-line note without opening the edit form.

Change

  • New shared/components/NoteButton.vue:
    • a notebook button (pi-book), rendered only when the row has a note;
    • it opens a PrimeVue Popover below it with the full note on a small notepad sheet: very pale yellow, horizontal rules the lines sit on, a red margin line (mirrored in RTL);
    • line breaks are kept, and long notes scroll inside the sheet.
  • AdminsView.vue: the Note column is removed; the button sits before Edit (and on your own row before the configs button).
  • UsersView.vue:
    • the button sits before Edit in the table, and before ⋯ on the phone cards;
    • the actions keep their place on every row (aligned to the end), so Edit and ⋯ line up whether or not there is a note;
    • the actions column is 6rem → 8rem.

Screenshots

Before After
before after
before after
before after
before after
before after
before after
before after

Tested

  • Deployed to main, node1 and node2 (UI).
  • On main: Admins and Users in light, dark, phone width and Persian (RTL). The button shows only on rows with a note. The sheet opens and closes (button or outside click), and multi-line notes sit on the rules.
  • RTL: the sheet's mirrored layout is scoped with html[dir='rtl'] .note-sheet. An earlier push used :global([dir='rtl']) .note-sheet, which compiles to a bare [dir="rtl"] rule and put the sheet's padding and ruled background on the whole page in Persian. That is fixed here; the page and the sheet were checked in Persian at phone width.
  • vue-tsc adds no errors.

Review

  • Confidence: High (>90%): display only; no API or data change, existing translation keys.
  • Complexity: Simple: one new component used in two views.

Rebased on dev after #108 was merged.

🤖 Generated with Claude Code

@hiddify-com

Copy link
Copy Markdown
Contributor

فکر میکنم اگر روی خود متن نوت بزنیم و اینجوری باز بشه بهتره تا اینکه یک دکمه دیگه به UI اضافه کنیم
هر دکمه پیچیدگی و گیح کنندگی اضافه میکنه

A notebook button before Edit, only on rows with a note, opens the note on
a small pale-yellow ruled sheet. The Admins page loses its Note column.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants