Repository navigation
fix(users): blank Users page on phones in RTL - #116
Open
Hiddify-Official wants to merge 1 commit into
Open
Hiddify-Official wants to merge 1 commit into
Hiddify-Official wants to merge 1 commit into
Conversation
… whole page)
":global([dir='rtl']) .u-sorts" compiles to a bare [dir='rtl'] {} in scoped CSS, so in RTL the
sort strip's fade mask was applied to the page itself; phone browsers then stopped painting the
page part way down. The fade is now a gradient drawn over the strip's end (html[dir='rtl'] for
its direction), with no mask-image.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #108, on phones in an RTL language (Persian) the Users page is drawn narrower than the screen and stops painting after the first few cards: the rest of the page stays blank. Users reported it on most mobile browsers.
Root cause:
:global([dir='rtl']) .u-sorts { mask-image: … }in scoped CSS compiles to a bare[dir="rtl"] { mask-image: … }, because Vue drops what follows:global(). So the sort strip's fade mask was applied to the whole page.Change
features/users/views/UsersView.vue:.u-sorts-wrap::after, the bar's own background color,pointer-events: none), with nomask-image;html[dir='rtl'] .u-sorts-wrap::after, the form the repo already recommends inAddDomainWizard.vue.Screenshots
Users page at phone width, Persian:
Tested
:global([dir…]) .xrule in admin_v2. feat(admin): notes on a notepad sheet next to Edit (Admins, Users) #107 had the same pattern and is fixed in that PR.Review
Fixes a regression from #108.
🤖 Generated with Claude Code