Repository navigation
cleanup support #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
cleanup support #268
Changes from all commits
d7ca070
7bbc177
d99c322
0f8b916
016f8fd
1114cbf
74d4d13
d86775b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,7 @@ class TarArchiveResourceStorage : public ResourceStorage | |
| std::unique_ptr< ResourceStorage > create_directory( const char* key ) override; | ||
| std::unique_ptr< ResourceStorage > directory( const char* key ) override; | ||
| bool exists( const char* key ) override; | ||
| void remove( const char* key ) override; | ||
|
|
||
| protected: | ||
| std::shared_ptr< std::ostream > create_output_stream( const char* key ) override; | ||
|
|
@@ -123,4 +124,11 @@ TarArchiveResourceStorage::exists( const char* key ) | |
| return m_storage->read( get_path( key ).c_str( ) ).data( ) != nullptr; | ||
| } | ||
|
|
||
| inline void | ||
| TarArchiveResourceStorage::remove( const char* /* key */ ) | ||
| { | ||
| // Removing parts of TAR files is not supported | ||
| throw std::runtime_error( "Removing from TAR files is not supported" ); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we normally do not throw to report errors -> use error return paths?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Initially I had it return a |
||
| } | ||
|
|
||
| } // namespace flatdata | ||
Uh oh!
There was an error while loading. Please reload this page.