Repository navigation
cleanup support - #268
cleanup support#268ChaoJia wants to merge 8 commits into
Conversation
| TarArchiveResourceStorage::remove( const char* /* key */ ) | ||
| { | ||
| // not supported since to TAR files is not supported | ||
| throw std::runtime_error( "Removing from TAR files is not supported" ); |
There was a problem hiding this comment.
I think we normally do not throw to report errors -> use error return paths?
There was a problem hiding this comment.
Initially I had it return a bool in the c++ implementation, but later for the rust implementation I went with Result<(), io::Error>. which seems to me is essentially equivalent to exception in c++: if it's not handled anywhere along the call stack, it will lead to crash. Returned bool can easily get ignored. Should I return a bool or an error code for the c++ implementation?
| /// remove resource and the corresponding schema | ||
| /// fail if resource or schema is missing or the existing schema doesn't match the expected | ||
| /// schema | ||
| #[doc(hidden)] |
There was a problem hiding this comment.
I think this function is only supposed to be used in the generated clean_up functions. It doesn't seem to make sense to me to call this function explicitly on the consumer end, or is there a real use case for this?
| } | ||
|
|
||
| /// remove multivector index resource | ||
| #[doc(hidden)] |
|
You need to sign off the commits (see failed DCO checks) |
Signed-off-by: Chao Jia <chao.jia@here.com>
Signed-off-by: Chao Jia <chao.jia@here.com>
Signed-off-by: Chao Jia <chao.jia@here.com>
Signed-off-by: Chao Jia <chao.jia@here.com>
Signed-off-by: Chao Jia <chao.jia@here.com>
Co-authored-by: epavese <epavese@gmail.com> Signed-off-by: Chao Jia <chao.jia@here.com>
Signed-off-by: Chao Jia <chao.jia@here.com>
08785e5 to
74d4d13
Compare
add cleanup support for flatdata.