Repository navigation
fix(selection): exclude indexers over the per-entity price cap - #284
Merged
Merged
Conversation
This was referenced Oct 22, 2026
MoonBoi9001
marked this pull request as ready for review
October 23, 2026 11:21
Dipper caps what it pays per billion entities, but selection only filtered on the monthly base price. Both selection and the DIPs-accepting list now take that cap and drop indexers above it; an indexer with no per-entity price still passes, since it is offered 0 per entity.
A ceiling of NaN, infinity or below 0 would quietly drop every indexer with a per-entity price. Both endpoints now refuse such a value with a 422, so a bad caller setting fails loudly.
The dips-indexers endpoint description lost 2 still-true details when the per-entity ceiling was added: a missing chain is rejected, and an omitted ceiling is not applied.
The selection request log printed none for a 0 GRT ceiling even though selection still applied it, hiding why every priced indexer was dropped.
MoonBoi9001
force-pushed
the
mb9/enforce-per-entity-price-ceiling
branch
from
October 26, 2026 12:34
8ac2d75 to
babce96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selection and the DIPs-accepting list now take an optional
max_grt_per_billion_entities_per_30_days, refuse it if negative or not a number, and drop indexers priced above it per entity, keeping any indexer with no per-entity price since dipper offers it 0. Dipper configures this ceiling, but nothing applied it, so an indexer could be picked at any per-entity price. The dipper side is graphprotocol/dipper#759.