Repository navigation
fix(selection): reject a negative or non-numeric base price cap - #300
Merged
MoonBoi9001 merged 2 commits intoOct 26, 2026
Merged
MoonBoi9001 merged 2 commits into
MoonBoi9001 merged 2 commits into
Conversation
A base price ceiling of NaN, infinity or below 0 would quietly drop every priced indexer. Both endpoints now refuse one with a 422, as they already do for the per-entity ceiling.
The standard error reply repeats the rejected value, and NaN or infinity can't be written as JSON, so a bad price cap in a selection request crashed the reply. Such values are now sent as text.
MoonBoi9001
force-pushed
the
mb9/reject-unusable-base-price-ceiling
branch
from
October 26, 2026 12:34
4c7ceed to
a28422f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both selection endpoints now refuse a
max_grt_per_30_daysthat is negative, infinite or not a number with a 422, as #284 already does for the per-entity cap, and a NaN or infinite cap in a request body now gets that 422 instead of a 500. Such a value would otherwise quietly drop every indexer with a price. Stacked on #284.