Repository navigation
Decouple Motion Photo extractor from MotionPhotoChecker and track exact video/image offsets - #7
Merged
Conversation
DichenZhang1
force-pushed
the
fix/decouple-extractor-from-checker
branch
from
October 6, 2026 18:52
f57e266 to
1da3d67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decouples
ExtractMotionPhotofromMotionPhotoCheckerso that extracting primary image, video track, and metadata does not require passing strict 1P checker validations first.Changes
motion_photo_checker_extractor_common.{h,cc}: SplitParseXmpMetadata()out ofParseAndCheckXmpMetadata()soExtractMotionPhotocan parse XMP metadata directly without runningMotionPhotoCheckerrules.motion_photo_extractor/function.cc:MotionPhotoCheckerdependency and calls (ParseAndCheckXmpMetadata,ReadDecodeAndCheckVideoMetadata) fromExtractMotionPhoto.MetadataEngineextraction fast-path withengine.IsMotionPhoto(collection).motion_photo_extractor_test.cc: Add unit test (ExtractionBypassesCheckerValidation) verifying thatMotionPhotoExtractorFunctionextracts primary image and video cleanly without runningMotionPhotoChecker.