Repository navigation
[libmotionphoto] Promote Development to main (HEIC/AVIF detection without libheif & extractor decoupling) - #9
Merged
Merged
Conversation
Decouple Motion Photo extractor from MotionPhotoChecker and track exact video/image offsets
fix(heif): detect HEIC and AVIF motion photos without libheif
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes
Development(b09d29d) intomain, bringing in:PR Decouple Motion Photo extractor from MotionPhotoChecker and track exact video/image offsets #7 (
562d71f) — Decouple Motion Photo extractor fromMotionPhotoCheckerand track exact video/image offsets:ParseXmpMetadata()out ofParseAndCheckXmpMetadata()inmotion_photo_checker_extractor_common.{h,cc}.MotionPhotoCheckercalls fromExtractMotionPhotoinmotion_photo_extractor/function.ccand guards the 3PMetadataEngineextraction fast-path withengine.IsMotionPhoto(collection).ExtractionBypassesCheckerValidationunit test inmotion_photo_extractor_test.cc.PR fix(heif): detect HEIC and AVIF motion photos without libheif #8 (
b09d29d) — Detect HEIC and AVIF motion photos withoutlibheif:CreateHeifContainerSplitter()inheif_container_splitter.cc(container_splitter.h,jpeg_container_splitter.cc,metadata_engine.cc).SniffFileType()inmotion_photo_jni.ccso JNIparseMetadata/parseMetadataFdand AGTM entry points detectftypHEIC/AVIF inputs.heif_container_splitter_test.cc,libmotionphoto_api_test.cc, andMetadataEngineTest.java.Verification
./build.sh && ./test.sh): 74/74 tests passed./tools/check_api_doc.sh): Passedarm64-v8aJNI build: Passed